Skip to content

Simplify Response Validation in OpenSaml5AuthenticationProvider #16915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jzheaux opened this issue Apr 9, 2025 · 0 comments
Closed

Simplify Response Validation in OpenSaml5AuthenticationProvider #16915

jzheaux opened this issue Apr 9, 2025 · 0 comments
Assignees
Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Milestone

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Apr 9, 2025

Related to #14264

To remove a validation step from the default validator, it is necessary to delegate to it and then remove any unwanted error messages.

The alternative to this is to create a validator using a number of OpenSaml5AuthenticationProvider's private methods.

We can alleviate this unwanted checking (and then removing those results) and well as make the most common validation steps available by exposing those converters in OpenSaml5AuthenticationProvider.

@jzheaux jzheaux added in: saml2 An issue in SAML2 modules type: enhancement A general enhancement labels Apr 9, 2025
@jzheaux jzheaux added this to the 6.5.0-RC1 milestone Apr 9, 2025
@jzheaux jzheaux self-assigned this Apr 9, 2025
@jzheaux jzheaux closed this as completed in 3e686ab Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant