Skip to content

OTT Should Use non-static member to capture the last OneTimeToken #16471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rwinch opened this issue Jan 23, 2025 · 0 comments
Closed

OTT Should Use non-static member to capture the last OneTimeToken #16471

rwinch opened this issue Jan 23, 2025 · 0 comments
Assignees
@rwinch
Labels
in: build An issue in the build type: bug A general bug
Milestone
6.4.3

Comments

@rwinch
Copy link
Member

rwinch commented Jan 23, 2025

OneTimeTokenLoginConfiguererTests & OneTimeTokenLoginDslTests are flakey because they use a static member variable to capture the OneTimeToken. Since the tests run in parallel one test may override the captured value which can cause the assertion to fail.

Instead, a non-static member should be used. The value can be referenced by accessing the member variable from a Bean.
@rwinch rwinch added in: build An issue in the build type: bug A general bug labels Jan 23, 2025
@rwinch rwinch added this to the 6.4.3 milestone Jan 23, 2025
@rwinch rwinch self-assigned this Jan 23, 2025
@rwinch rwinch mentioned this issue Jan 23, 2025
Closed
@rwinch rwinch closed this as completed in 751b558 Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwinch rwinch

Labels
in: build An issue in the build type: bug A general bug
Projects
None yet
Milestone
6.4.3
Development

No branches or pull requests
1 participant
@rwinch