Skip to content

Commit fc8a018

Browse files
committed
Polish Dispose default Scheduler
1 parent e0414e5 commit fc8a018

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

core/src/main/java/org/springframework/security/authentication/AbstractUserDetailsReactiveAuthenticationManager.java

+4-9
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,9 @@ public abstract class AbstractUserDetailsReactiveAuthenticationManager implement
5656

5757
private ReactiveUserDetailsPasswordService userDetailsPasswordService;
5858

59-
Scheduler scheduler = Schedulers.newParallel("password-encoder");
60-
private boolean defaultScheduler = true;
59+
private final Scheduler DEFAULT_SCHEDULER = Schedulers.newParallel("password-encoder");
60+
61+
private Scheduler scheduler = this.DEFAULT_SCHEDULER;
6162

6263
private UserDetailsChecker preAuthenticationChecks = user -> {
6364
if (!user.isAccountNonLocked()) {
@@ -140,10 +141,6 @@ public void setPasswordEncoder(PasswordEncoder passwordEncoder) {
140141
*/
141142
public void setScheduler(Scheduler scheduler) {
142143
Assert.notNull(scheduler, "scheduler cannot be null");
143-
if (this.defaultScheduler) {
144-
this.defaultScheduler = false;
145-
this.scheduler.dispose();
146-
}
147144
this.scheduler = scheduler;
148145
}
149146

@@ -179,8 +176,6 @@ public void setPostAuthenticationChecks(UserDetailsChecker postAuthenticationChe
179176

180177
@Override
181178
public void destroy() {
182-
if (this.defaultScheduler) {
183-
this.scheduler.dispose();
184-
}
179+
this.DEFAULT_SCHEDULER.dispose();
185180
}
186181
}

0 commit comments

Comments
 (0)