withValue used incorrectly

neveler · jzheaux · commit e31f04bebcaf · 2025-02-03T10:18:33.000-07:00
Closes gh-16525 Closes gh-16527 Signed-off-by: NeoTraveler <55753029+NeoTraveler@users.noreply.github.com>
diff --git a/web/src/main/java/org/springframework/security/web/authentication/ui/DefaultLoginPageGeneratingFilter.java b/web/src/main/java/org/springframework/security/web/authentication/ui/DefaultLoginPageGeneratingFilter.java
@@ -286,7 +286,7 @@ private String renderFormLogin(HttpServletRequest request, boolean loginError, b
 			.withValue("passwordParameter", this.passwordParameter)
 			.withRawHtml("rememberMeInput", renderRememberMe(this.rememberMeParameter))
 			.withRawHtml("hiddenInputs", hiddenInputs)
-			.withValue("autocomplete", this.passkeysEnabled ? "autocomplete=\"password webauthn\"" : "")
+			.withRawHtml("autocomplete", this.passkeysEnabled ? "autocomplete=\"password webauthn\" " : "")
 			.render();
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -286,7 +286,7 @@ private String renderFormLogin(HttpServletRequest request, boolean loginError, b`
`286`	`286`	`.withValue("passwordParameter", this.passwordParameter)`
`287`	`287`	`.withRawHtml("rememberMeInput", renderRememberMe(this.rememberMeParameter))`
`288`	`288`	`.withRawHtml("hiddenInputs", hiddenInputs)`
`289`		`- .withValue("autocomplete", this.passkeysEnabled ? "autocomplete=\"password webauthn\"" : "")`
	`289`	`+ .withRawHtml("autocomplete", this.passkeysEnabled ? "autocomplete=\"password webauthn\" " : "")`
`290`	`290`	`.render();`
`291`	`291`	`}`
`292`	`292`