Skip to content

Commit d6fac11

Browse files
Merge branch '6.1.x'
2 parents 27f0ab9 + e916e44 commit d6fac11

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

saml2/saml2-service-provider/src/main/java/org/springframework/security/saml2/provider/service/web/Saml2MetadataFilter.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ private void writeMetadataToResponse(HttpServletResponse response, Saml2Metadata
108108
String fileName = metadata.getFileName();
109109
String encodedFileName = URLEncoder.encode(fileName, StandardCharsets.UTF_8.name());
110110
response.setHeader(HttpHeaders.CONTENT_DISPOSITION, String.format(format, fileName, encodedFileName));
111-
response.setContentLength(metadata.getMetadata().length());
111+
response.setContentLength(metadata.getMetadata().getBytes(StandardCharsets.UTF_8).length);
112112
response.setCharacterEncoding(StandardCharsets.UTF_8.name());
113113
response.getWriter().write(metadata.getMetadata());
114114
}

saml2/saml2-service-provider/src/test/java/org/springframework/security/saml2/provider/service/web/Saml2MetadataFilterTests.java

+2
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,8 @@ public void doFilterWhenCharacterEncodingThenEncodeSpecialCharactersCorrectly()
177177
this.filter.doFilter(this.request, this.response, this.chain);
178178
assertThat(this.response.getCharacterEncoding()).isEqualTo(StandardCharsets.UTF_8.name());
179179
assertThat(this.response.getContentAsString(StandardCharsets.UTF_8)).isEqualTo(generatedMetadata);
180+
assertThat(this.response.getContentLength())
181+
.isEqualTo(generatedMetadata.getBytes(StandardCharsets.UTF_8).length);
180182
}
181183

182184
@Test

0 commit comments

Comments
 (0)