Skip to content

Add delete(Predicate) to QuerydslJpaPredicateExecutor #3878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 94 commits into
base: 4.0.x
Choose a base branch
from
Open

Add delete(Predicate) to QuerydslJpaPredicateExecutor #3878

wants to merge 94 commits into from

Conversation

mp911de
Copy link
Member

@mp911de mp911de commented May 9, 2025

We now define a delete method to remove entities using a Querydsl Predicate and return the count of deleted elements.

Closes #3877

mp911de and others added 30 commits April 14, 2025 09:03
@mp911de
Prepare next development iteration.
d28e2ed 
See #3680
@mp911de
After release cleanups.
5a2cdb3 
See #3680
@mp911de
Adopt to deprecation removals in Commons.
0fccd8d 
Closes #3683
@mp911de
Replace derived CriteriaQuery with String-based queries.
e6b3b53 
Introduce new DSL to construct JPQL queries. Refactor ParameterMetadata to PartTreeParameterBinding.

Disable Keyset pagination with projections for Eclipselink as Eclipselink doesn't consider type hints for JPQL queries.

Closes #3588
Original pull request: #3653
@christophstrobl @mp911de
Polishing.
b88a205 
Make usage of ParameterExpression more explicit. Add JPQL rendering tests.
Favor Metamodel over From for building jpql queries.
Align IsNull and IsNotNull handling.
Support Derived Delete and Exists, consider null values when caching queries.

See #3588
Original pull request: #3653
@mp911de
Polishing.
8e3eb4f 
Remove method overloads accepting pure strings. Use switch-expressions. Correctly navigate nested joins. Introduce PathExpression interface, refine naming.

See #3588
Original pull request: #3653
@mp911de
Revise PartTree query caching.
57b190f 
See #3588
Original pull request: #3653
@mp911de
Upgrade to JPA 3.2.
507dce6 
Closes: #3673
Original Pull Request: #3695
@mp911de
Upgrade to Hibernate 7.0 Beta1.
66afbfd 
Closes: #3671
Original Pull Request: #3695
@mp911de
Upgrade to Eclipselink 5.0.0-B05.
ab44631 
Closes: #3672
Original Pull Request: #3695
@christophstrobl @mp911de
Switch XML persistence & orm files to version 3.2
c3efdcf 
See: #3673
Original Pull Request: #3695
@mp911de
Consider NULLS precedence using Sort for Criteria Queries.
53243d7 
Closes: #3587
Original Pull Request: #3695
@gregturn @mp911de
Add support for JPA 3.2 additions to JPQL.
4b30241 
See: #3136
Original Pull Request: #3695
@christophstrobl @mp911de
Add support for JPA 3.2 additions to EQL.
ec75aae 
See: #3136
Original Pull Request: #3695
@christophstrobl @mp911de
Make sure sorting is rendered correctly for JPQL query using set oper…
8d8d901 
…ator.

Original Pull Request: #3695
@mp911de
Polishing.
e7fde06 
Inline select_query into select_statement, simplify set_function resolution.
Align JPQL and EQL grammars.
Adopt Hibernate version guards in tests.

Original Pull Request: #3695
@mp911de
Fix EQL grammar to accept literals in constructor expressions.
2eaf93e 
Original Pull Request: #3695
@mp911de
Cleanup QueryTokenStream methods.
9c8fc91 
Remove unused methods. Introduce QueryTokenStream.from and QueryTokenStream.ofToken() factory methods. Migrate JPQL visitors to consistently return token streams instead of mixing expression streams when obtaining values from nodes/terminal nodes.

Remove also unused concat methods for consistency.

We now instead decide on the composition (calling) site whether a token (stream) should be inlined, an expression or used as-is.

Original Pull Request: #3695
@mp911de
Switch to Query.getSingleResultOrNull().
e442ed8 
We now use getSingleResultOrNull() to avoid NoResultException handling.

Closes: #3701
Original Pull Request: #3695
@christophstrobl @mp911de
Move off deprecated TemporalType.TIMESTAMP
2f64225 
Favour java.time types for auditing by switching from Date to Instant.

See: #3673
Original Pull Request: #3695
@christophstrobl @mp911de
Polishing.
b4199e3 
A round of minor code style improvements.

Original Pull Request: #3695
@mp911de
Extend license header copyright years to 2025.
12452f0 
See #3734
@mp911de
Remove commons-logging exclusion.
9420153 
Closes #3736
@mp911de
Explore refined Specification API.
8d942bd 
Introduce DeleteSpecification and UpdateSpecification. Add PredicateSpecification. Update SpecificationExecutor.

Closes: #3521
Original Pull Request: #3578
@christophstrobl @mp911de
Remove Specification.where method in favour of all().
6fac30a 
Also remove serialVersionUID.

Original Pull Request: #3578
@mp911de
Polishing.
a3e8518 
Revise nullability requirements around non-nullable specifications.

Original Pull Request: #3578
@mp911de
Add Contract annotations.
b863511 
Original Pull Request: #3578
@mp911de
Address review findings.
fd878f3 
Original Pull Request: #3578
@mp911de
Polishing.
de7dd80 
Refine JOIN and function keyword rendering.

See #3692
@mp911de
Merge (Hql|Jpql|Eql)SpecificationTests with their corresponding `Qu…
00034da 
…eryRendererTests`.

Closes #3692
mp911de and others added 23 commits April 22, 2025 10:37
@mp911de
Polishing.
1ca26d8 
Fix post-rebase conflicts.

See #3622
@mp911de
Polishing.
9d3ecbb 
Refine documentation.

See #3815
@mp911de
Prepare 4.0 M2 (2025.1.0).
07d1d55 
See #3751
@mp911de
Release version 4.0 M2 (2025.1.0).
4ddd4b8 
See #3751
@mp911de
Prepare next development iteration.
5d8cf2c 
See #3751
@mp911de
After release cleanups.
3827c3c 
See #3751
@mp911de
Use parameter names in derived JPQL queries.
d6482ff 
We also use improved parameter naming for keyset queries for easier correlation of values.

Closes #3857
@mp911de
Polishing.
9fab81a 
Add dynamic projection benchmark.
@SWQXDBA @mp911de
Fix handling of null predicate in Specification.not().
c94259c 
When toPredicate() returns null, Specification.not() now returns
builder.disjunction() instead of builder.not(null). This change
ensures proper handling of null predicates in negated specifications.

Closes #3849
Original pull request: #3856

Signed-off-by: SWQXDBA <983110853@qq.com>
@mp911de
Polishing.
15b3241 
Add fix to Update, Delete, and PredicateSpecification. Reformat code. Refine tests.

See #3849
Original pull request: #3856
@mp911de
Avoid DTO Constructor Expression rewriting for selection of nested pr…
2a4559c 
…operties.

We back off from rewriting String-based queries to use DTO Constructor expressions if the query selects a property that is assignable to the return type.

Closes #3862
@thmasker @mp911de
Removes PlainSelect casting in JSqlParserQueryEnhancer.
7520e29 
Closes: #3869
Original pull request: #3870

Signed-off-by: Diego Pedregal <diego.p.hidalgo@gmail.com>
@mp911de
Polishing.
f02a21c 
Introduce doWithPlainSelect(…) callback for easier filtering of Select subtypes. Add test for known (previously) failing case.

See: #3869
Original pull request: #3870
@christophstrobl
Upgrade to Hibernate 7.0.0.CR1.
3503b33 
Closes: #3872
@mp911de
Provide JpaRepositoryFragmentsContributor in JPA Repository Factory…
86c1d38 
… and Repository Factory Bean.

Closes #3874
@mp911de
Use LocalVariableNameFactory in repository contributor.
beab651 
Closes #3875
@mp911de
Use isolated Hibernate EntityManager for AOT contribution.
cf6dee9 
Closes #3876
@mp911de
Use dynamic copyright years in documentation, adopt to feature flags.
bc54aec 
See #3853
@Lidoca @mp911de
Document OpenFeign Querydsl usage.
aaa1cac 
Signed-off-by: Lidoca <32785562+Lidoca@users.noreply.github.com>

Closes #3859
@mp911de
Polishing.
ef7761c 
Merge Openfeign setup tabs.

See #3859
@mp911de
Fliter jakarta.persistence types from AOT Metamodel.
db5a441 
Otherwise, Hibernate fails with weird resolution errors.

See #3872
@mp911de
Use SelectionQuery.getResultCount() for count queries if possible.
cdcac86 
We now use Hibernate's built-in mechanism to obtain the result count if there is an enclosing transaction. Without the transaction, the session is being closed and we cannot run the query.

Closes #3456
@mp911de
Prepare issue branch.
67421ce
@mp911de mp911de added the type: enhancement A general enhancement label May 9, 2025
@mp911de mp911de linked an issue May 9, 2025 that may be closed by this pull request
Add delete(Predicate) to QuerydslJpaPredicateExecutor #3877
Open
@mp911de
Add delete(Predicate) to QuerydslJpaPredicateExecutor.
74cd50a 
We now define a delete method to remove entities by a Querydsl Predicate and return the count of deleted elements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schauder schauder Awaiting requested review from schauder

@christophstrobl christophstrobl Awaiting requested review from christophstrobl

Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add delete(Predicate) to QuerydslJpaPredicateExecutor
10 participants
@mp911de @christophstrobl @gregturn @JoshuaChen @quaff @hgh1472 @yybmion @SWQXDBA @thmasker @Lidoca