Skip to content

Add support for Bitnami container images with Docker Compose #35759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wilkinsona opened this issue Jun 6, 2023 · 2 comments
Closed

Add support for Bitnami container images with Docker Compose #35759

wilkinsona opened this issue Jun 6, 2023 · 2 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@wilkinsona
Copy link
Member

wilkinsona commented Jun 6, 2023

We want to investigate how compatible our Docker Compose support is with Bitnami container images. The first part of this is the names of the images as we use the name to determine the type of the service in the container. If these don't match up, the org.springframework.boot.service-connection label can be used to as something of a workaround but it would be nice if it wasn't necessary. The second part of this is the environment variables in the started container that we look for to learn how to connect to the service. If the Binami images use different environment variables, we won't be able to figure out how to connect. I'm not sure that this can be worked around – perhaps by a user configuring custom environment variables that alias one variable to another – but this would be even clunkier than the image name workaround.

@wilkinsona wilkinsona added the type: task A general task label Jun 6, 2023
@wilkinsona wilkinsona added this to the 3.1.x milestone Jun 6, 2023
@wilkinsona wilkinsona changed the title Investigate Docker Compose support's compatibility with Bitnami docker images Investigate Docker Compose support's compatibility with Bitnami container images Jun 6, 2023
@wilkinsona
Copy link
Member Author

Results of using the changes in this branch to try the Bitnami container images:

Official Bitnami Notes
cassandra bitnami/cassandra Basics work with org.springframework.boot.service-connection: cassandra
elasticsearch bitnami/elasticsearch Service never becomes ready (Connection refused)
gvenzl/oracle-xe No Bitnami image available
mariadb bitnami/mariadb Basics work with org.springframework.boot.service-connection: mariadb
mongo bitnami/mongodb Basics work with org.springframework.boot.service-connection: mongo
mssql/server No Bitnami image available
mysql bitnami/mysql Basics work with org.springframework.boot.service-connection: mysql
openzipkin/zipkin No Bitnami image available
postgres bitnami/postgresql Basics work with org.springframework.boot.service-connection: postgres
rabbitmq bitnami/rabbitmq Basics work with org.springframework.boot.service-connection: rabbitmq
redis bitnami/redis Container fails to start as neither REDIS_PASSWORD nor ALLOW_EMPTY_PASSWORD is set

This testing is fairly superficial. A second pass to look at the environment variables that each container supports and whether they work as expected is the next step.

@mpermar
Copy link

mpermar commented Jul 6, 2023

I'm likely stating the obvious here but the following changes fix the Elasticsearch and Redis composes:

services:
  elasticsearch:
    image: 'elasticsearch:8.6.1'
    environment:
      - 'ELASTIC_PASSWORD=secret'
      - 'ES_JAVA_OPTS=-Xmx1024m'
      - 'xpack.security.enabled=false'
      - 'discovery.type=single-node'
    ports:
      - '9200'
      - '9300'

and

services:
  redis:
    image: 'bitnami/redis:7.0'
    environment:
      - 'ALLOW_EMPTY_PASSWORD=yes'
    ports:
      - '6379:6379'
    labels:
      org.springframework.boot.service-connection: redis

@philwebb philwebb added the for: team-meeting An issue we'd like to discuss as a team to make progress label Nov 8, 2023
@philwebb philwebb modified the milestones: 3.1.x, 3.x Nov 8, 2023
@scottfrederick scottfrederick removed the for: team-meeting An issue we'd like to discuss as a team to make progress label Nov 8, 2023
@scottfrederick scottfrederick self-assigned this Nov 27, 2023
@scottfrederick scottfrederick added type: enhancement A general enhancement and removed type: task A general task labels Feb 8, 2024
@scottfrederick scottfrederick modified the milestones: 3.x, 3.3.x Feb 8, 2024
@scottfrederick scottfrederick changed the title Investigate Docker Compose support's compatibility with Bitnami container images Add support for Bitnami container images with Docker Compose Feb 8, 2024
@scottfrederick scottfrederick modified the milestones: 3.3.x, 3.3.0-M2 Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

4 participants