Skip to content

Commit 5a4ac12

Browse files
wilkinsonaPhillip Webb
authored and
Phillip Webb
committed
Remove superfluous starter dependencies
Remove superfluous dependencies from spring-boot-starter-tomcat and spring-boot-starter-jetty which caused gradle based builds to put too many libraries in `/lib-provided` when building a war. Fixes gh-1064
1 parent 3341a5d commit 5a4ac12

File tree

2 files changed

+0
-28
lines changed
  • spring-boot-starters

2 files changed

+0
-28
lines changed

spring-boot-starters/spring-boot-starter-jetty/pom.xml

-14
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,6 @@
1818
<main.basedir>${basedir}/../..</main.basedir>
1919
</properties>
2020
<dependencies>
21-
<dependency>
22-
<groupId>org.springframework.boot</groupId>
23-
<artifactId>spring-boot-starter</artifactId>
24-
</dependency>
2521
<dependency>
2622
<groupId>org.eclipse.jetty</groupId>
2723
<artifactId>jetty-webapp</artifactId>
@@ -30,15 +26,5 @@
3026
<groupId>org.eclipse.jetty</groupId>
3127
<artifactId>jetty-jsp</artifactId>
3228
</dependency>
33-
<dependency>
34-
<groupId>org.springframework</groupId>
35-
<artifactId>spring-core</artifactId>
36-
<exclusions>
37-
<exclusion>
38-
<groupId>commons-logging</groupId>
39-
<artifactId>commons-logging</artifactId>
40-
</exclusion>
41-
</exclusions>
42-
</dependency>
4329
</dependencies>
4430
</project>

spring-boot-starters/spring-boot-starter-tomcat/pom.xml

-14
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,6 @@
1818
<main.basedir>${basedir}/../..</main.basedir>
1919
</properties>
2020
<dependencies>
21-
<dependency>
22-
<groupId>org.springframework.boot</groupId>
23-
<artifactId>spring-boot-starter</artifactId>
24-
</dependency>
2521
<dependency>
2622
<groupId>org.apache.tomcat.embed</groupId>
2723
<artifactId>tomcat-embed-core</artifactId>
@@ -34,15 +30,5 @@
3430
<groupId>org.apache.tomcat.embed</groupId>
3531
<artifactId>tomcat-embed-logging-juli</artifactId>
3632
</dependency>
37-
<dependency>
38-
<groupId>org.springframework</groupId>
39-
<artifactId>spring-core</artifactId>
40-
<exclusions>
41-
<exclusion>
42-
<groupId>commons-logging</groupId>
43-
<artifactId>commons-logging</artifactId>
44-
</exclusion>
45-
</exclusions>
46-
</dependency>
4733
</dependencies>
4834
</project>

0 commit comments

Comments
 (0)