Feedback. Part 5.

#436 (comment)

Author: fhanik

samples/service-provider/starter/src/main/java/org/springframework/security/config/annotation/web/configurers/Saml2ServiceProviderConfigurer.java

@@ -57,7 +57,7 @@ public Saml2ServiceProviderConfigurer serviceProviderEntityId(String entityId) {
 		return this;
 	}
 
-	public Saml2ServiceProviderConfigurer addServiceProviderKey(Saml2X509Credential key) {
+	public Saml2ServiceProviderConfigurer addServiceProviderCredentials(Saml2X509Credential key) {
 		this.spCredentials.add(key);
 		return this;
 	}

samples/service-provider/starter/src/main/java/sample/SecurityConfig.java

@@ -43,7 +43,7 @@ protected void configure(HttpSecurity http) throws Exception {
 			.apply(
 				Saml2ServiceProviderConfigurer.saml2Login()
 					.serviceProviderEntityId("http://localhost:8080/sample-sp")
-					.addServiceProviderKey(getLocalSpKey())
+					.addServiceProviderCredentials(getLocalSpCredentials())
 					.addIdentityProvider(
 						new Saml2IdentityProviderDetails(
 							"http://simplesaml-for-spring-saml.cfapps.io/saml2/idp/metadata.php",
@@ -62,7 +62,7 @@ protected void configure(HttpSecurity http) throws Exception {
 		//@formatter:on
 	}
 
-	private Saml2X509Credential getLocalSpKey() {
+	private Saml2X509Credential getLocalSpCredentials() {
 		PrivateKey pkey = readPrivateKey(privateKey, privateKeyPassphrase);
 		X509Certificate spCert = getCertificate(certificate);
 		return new Saml2X509Credential(pkey, spCert);