Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Commit 35f0b0c

Browse files
committed
some review fixes
1 parent 64c14b9 commit 35f0b0c

File tree

4 files changed

+3
-6
lines changed

4 files changed

+3
-6
lines changed

cmd/frontend/graphqlbackend/schema.graphql

+2-1
Original file line numberDiff line numberDiff line change
@@ -1832,7 +1832,8 @@ type ExecutorSecretAccessLog implements Node {
18321832
executorSecret: ExecutorSecret!
18331833
"""
18341834
The user in which name the secret has been used.
1835-
This is null when the access was not by a user account.
1835+
This is null when the access was not by a user account, or
1836+
when the user account was deleted.
18361837
"""
18371838
user: User
18381839
"""

enterprise/cmd/frontend/internal/executorqueue/queues/codeintel/transform.go

+1
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ func transformRecord(ctx context.Context, index types.Index, db database.DB, res
4545
if len(index.RequestedEnvVars) > 0 {
4646
secretsStore := db.ExecutorSecrets(keyring.Default().ExecutorSecretKey)
4747
secrets, _, err = secretsStore.List(ctx, database.ExecutorSecretScopeCodeIntel, database.ExecutorSecretsListOpts{
48+
// Note: No namespace set, codeintel secrets are only available in the global namespace for now.
4849
Keys: index.RequestedEnvVars,
4950
})
5051
if err != nil {

enterprise/internal/codeintel/autoindexing/internal/jobselector/job_selector.go

-3
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ package jobselector
22

33
import (
44
"context"
5-
"fmt"
65
"os"
76

87
"github.com/sourcegraph/log"
@@ -251,8 +250,6 @@ func convertInferredConfiguration(repositoryID int, commit string, indexJobs []c
251250
})
252251
}
253252

254-
fmt.Println(indexJob.RequestedEnvVars)
255-
256253
indexes = append(indexes, types.Index{
257254
RepositoryID: repositoryID,
258255
Commit: commit,

go.sum

-2
Original file line numberDiff line numberDiff line change
@@ -2490,8 +2490,6 @@ golang.org/x/exp v0.0.0-20191227195350-da58074b4299/go.mod h1:2RIsYlXP63K8oxa1u0
24902490
golang.org/x/exp v0.0.0-20200119233911-0405dc783f0a/go.mod h1:2RIsYlXP63K8oxa1u096TMicItID8zy7Y6sNkU49FU4=
24912491
golang.org/x/exp v0.0.0-20200207192155-f17229e696bd/go.mod h1:J/WKrq2StrnmMY6+EHIKF9dgMWnmCNThgcyBT1FY9mM=
24922492
golang.org/x/exp v0.0.0-20200224162631-6cc2880d07d6/go.mod h1:3jZMyOhIsHpP37uCMkUooju7aAi5cS1Q23tOzKc+0MU=
2493-
golang.org/x/exp v0.0.0-20221208152030-732eee02a75a h1:4iLhBPcpqFmylhnkbY3W0ONLUYYkDAW9xMFLfxgsvCw=
2494-
golang.org/x/exp v0.0.0-20221208152030-732eee02a75a/go.mod h1:CxIveKay+FTh1D0yPZemJVgC/95VzuuOLq5Qi4xnoYc=
24952493
golang.org/x/image v0.0.0-20190227222117-0694c2d4d067/go.mod h1:kZ7UVZpmo3dzQBMxlp+ypCbDeSB+sBbTgSJuh5dn5js=
24962494
golang.org/x/image v0.0.0-20190802002840-cff245a6509b/go.mod h1:FeLwcggjj3mMvU+oOTbSwawSJRM1uh48EjtB4UJZlP0=
24972495
golang.org/x/lint v0.0.0-20180702182130-06c8688daad7/go.mod h1:UVdnD1Gm6xHRNCYTkRU2/jEulfH38KcIWyp/GAMgvoE=

0 commit comments

Comments
 (0)