[REFACTOR] Change {List-type property} to be read-only by removing the property setter (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2227)

Author: Gonzalo Diaz

src/algorithm_exercises_csharp/hackerrank/warmup/SimpleArraySum.cs

@@ -4,13 +4,13 @@ namespace algorithm_exercises_csharp.hackerrank.warmup;
 
 public static class SimpleArraySum
 {
-  public static int simpleArraySum(int[] inputs)
+  public static int simpleArraySum(List<int> ar)
   {
-    ArgumentNullException.ThrowIfNull(inputs);
+    ArgumentNullException.ThrowIfNull(ar);
 
     var total = 0;
 
-    foreach (int i in inputs)
+    foreach (int i in ar)
     {
       total += i;
     }

src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/arrays/NewYearChaos.Test.cs

@@ -5,11 +5,26 @@ namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.a
 [TestClass]
 public class NewYearChaosTest
 {
-  public class NewYearChaosTestCase
+  public class NewYearChaosTestCase(string title, int[] input, string expected)
   {
-    public string title { get; set; } = default!;
-    public List<int> input { get; set; } = default!;
-    public string expected { get; set; } = default!;
+    private readonly string title = title;
+    private readonly List<int> input = [.. input];
+    private readonly string expected = expected;
+
+    public string Title
+    {
+      get { return title; }
+    }
+
+    public List<int> Input
+    {
+      get { return input; }
+    }
+
+    public string Expected
+    {
+      get { return expected; }
+    }
   }
 
   private List<NewYearChaosTestCase> testCases { get; set; } = default!;
@@ -29,10 +44,10 @@ public void testMinimumBribesText()
 
     foreach (NewYearChaosTestCase test in testCases)
     {
-      result = NewYearChaos.minimumBribesText(test.input);
-      NewYearChaos.minimumBribes(test.input);
+      result = NewYearChaos.minimumBribesText(test.Input);
+      NewYearChaos.minimumBribes(test.Input);
 
-      Assert.AreEqual(test.expected, result);
+      Assert.AreEqual(test.Expected, result);
     }
   }
 }

src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/arrays/TwoDArray.Test.cs

@@ -5,11 +5,24 @@ namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.a
 [TestClass]
 public class TwoDArrayTest
 {
-  public class TwoDArrayTestCase
+  public class TwoDArrayTestCase(string title, List<List<int>> input, long expected)
   {
-    public string title { get; set; } = default!;
-    public List<List<int>> input { get; set; } = default!;
-    public long expected { get; set; } = default!;
+    private string title = title;
+    private List<List<int>> input = input;
+    private long expected = expected;
+
+    public string Title
+    {
+      get { return title; }
+    }
+    public List<List<int>> Input
+    {
+      get { return input; }
+    }
+    public long Expected
+    {
+      get { return expected; }
+    }
   }
 
   private List<TwoDArrayTestCase> testCases { get; set; } = default!;
@@ -29,8 +42,8 @@ public void testHourglassSum()
 
     foreach (TwoDArrayTestCase test in testCases)
     {
-      result = TwoDArray.hourglassSum(test.input);
-      Assert.AreEqual(test.expected, result);
+      result = TwoDArray.hourglassSum(test.Input);
+      Assert.AreEqual(test.Expected, result);
     }
   }
 

src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/CountTriplets.Test.cs

@@ -5,12 +5,32 @@ namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.d
 [TestClass]
 public class CountTripletsTest
 {
-  public class CountTripletsTestCase
+  public class CountTripletsTestCase(string title, long[] input, int r, long expected)
   {
-    public string title { get; set; } = default!;
-    public List<long> input { get; set; } = default!;
-    public int r { get; set; } = default!;
-    public long expected { get; set; } = default!;
+    private readonly string title = title;
+    private readonly List<long> input = [.. input];
+    private readonly int r = r;
+    private readonly long expected = expected;
+
+    public string Title
+    {
+      get { return title; }
+    }
+
+    public List<long> Input
+    {
+      get { return input; }
+    }
+
+    public int R
+    {
+      get { return r; }
+    }
+
+    public long Expected
+    {
+      get { return expected; }
+    }
   }
 
   private List<CountTripletsTestCase> testCases { get; set; } = default!;
@@ -35,14 +55,14 @@ public void testCountTriplets()
 
     foreach (CountTripletsTestCase test in testCases)
     {
-      result = CountTriplets.countTriplets(test.input, test.r);
-      Assert.AreEqual(test.expected, result);
+      result = CountTriplets.countTriplets(test.Input, test.R);
+      Assert.AreEqual(test.Expected, result);
     }
 
     foreach (CountTripletsTestCase test in bigTestCases)
     {
-      result = CountTriplets.countTriplets(test.input, test.r);
-      Assert.AreEqual(test.expected, result);
+      result = CountTriplets.countTriplets(test.Input, test.R);
+      Assert.AreEqual(test.Expected, result);
     }
   }
 }

src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/CountTripletsBruteForce.Test.cs

@@ -5,12 +5,32 @@ namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.d
 [TestClass]
 public class CountTripletsBruteForceTest
 {
-  public class CountTripletsBruteForceTestCase
+  public class CountTripletsBruteForceTestCase(string title, long[] input, int r, long expected)
   {
-    public string title { get; set; } = default!;
-    public List<long> input { get; set; } = default!;
-    public int r { get; set; } = default!;
-    public int expected { get; set; } = default!;
+    private readonly string title = title;
+    private readonly List<long> input = [.. input];
+    private readonly int r = r;
+    private readonly long expected = expected;
+
+    public string Title
+    {
+      get { return title; }
+    }
+
+    public List<long> Input
+    {
+      get { return input; }
+    }
+
+    public int R
+    {
+      get { return r; }
+    }
+
+    public long Expected
+    {
+      get { return expected; }
+    }
   }
 
   private List<CountTripletsBruteForceTestCase> testCases { get; set; } = default!;
@@ -30,8 +50,8 @@ public void testCountTriplets()
 
     foreach (CountTripletsBruteForceTestCase test in testCases)
     {
-      result = CountTripletsBruteForce.countTriplets(test.input, test.r);
-      Assert.AreEqual(test.expected, result);
+      result = CountTripletsBruteForce.countTriplets(test.Input, test.R);
+      Assert.AreEqual(test.Expected, result);
     }
   }
 }

src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/RansomNote.Test.cs

@@ -5,12 +5,32 @@ namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.d
 [TestClass]
 public class RansomNoteTest
 {
-  public class RansomNoteTestCase
+  public class RansomNoteTestCase(string title, List<string> magazine, List<string> note, string expected)
   {
-    public string title { get; set; } = default!;
-    public List<string> magazine { get; set; } = default!;
-    public List<string> note { get; set; } = default!;
-    public string expected { get; set; } = default!;
+    private readonly string title = title;
+    private readonly List<string> magazine = [.. magazine];
+    private readonly List<string> note = [.. note];
+    private readonly string expected = expected;
+
+    public string Title
+    {
+      get { return title; }
+    }
+
+    public List<string> Magazine
+    {
+      get { return magazine; }
+    }
+
+    public List<string> Note
+    {
+      get { return note; }
+    }
+
+    public string Expected
+    {
+      get { return expected; }
+    }
   }
 
   private List<RansomNoteTestCase> testCases { get; set; } = default!;
@@ -30,8 +50,8 @@ public void testCheckMagazine()
 
     foreach (RansomNoteTestCase test in testCases)
     {
-      result = RansomNote.checkMagazine(test.magazine, test.note);
-      Assert.AreEqual(test.expected, result);
+      result = RansomNote.checkMagazine(test.Magazine, test.Note);
+      Assert.AreEqual(test.Expected, result);
     }
   }
 }

src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/SherlockAndAnagrams.Test.cs

@@ -5,19 +5,25 @@ namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.d
 [TestClass]
 public class SherlockAndAnagramsTest
 {
-  public class SherlockAndAnagramsTestCase
+  public class TestCase
   {
-    /**
-     * SherlockAndAnagramsTestCase.TestCase.
-     */
-    public class TestCase
+    public string input { get; set; } = default!;
+    public int expected { get; set; } = default!;
+  }
+
+  public class SherlockAndAnagramsTestCase(string title, List<TestCase> tests)
+  {
+    private string title = title;
+    private List<TestCase> tests = tests;
+
+    public string Title
     {
-      public string input { get; set; } = default!;
-      public int expected { get; set; } = default!;
+      get { return title; }
+    }
+    public List<TestCase> Tests
+    {
+      get { return tests; }
     }
-
-    public string title { get; set; } = default!;
-    public List<TestCase> tests { get; set; } = default!;
   }
 
   private List<SherlockAndAnagramsTestCase> testCases { get; set; } = default!;
@@ -37,7 +43,7 @@ public void testSherlockAndAnagrams()
 
     foreach (SherlockAndAnagramsTestCase testSet in testCases)
     {
-      foreach (SherlockAndAnagramsTestCase.TestCase test in testSet.tests)
+      foreach (SherlockAndAnagramsTest.TestCase test in testSet.Tests)
       {
         result = SherlockAndAnagrams.sherlockAndAnagrams(test.input);
         Assert.AreEqual(test.expected, result);

src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/greedy_algorithms/MinimumAbsoluteDifferenceInAnArray.Test.cs

@@ -5,11 +5,24 @@ namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.g
 [TestClass]
 public class MinimumAbsoluteDifferenceInAnArrayTest
 {
-  public class MinimumAbsoluteDifferenceInAnArrayTestCase
+  public class MinimumAbsoluteDifferenceInAnArrayTestCase(string title, List<int> input, int expected)
   {
-    public string title = "";
-    public List<int> input = [];
-    public int expected;
+    private readonly string title = title;
+    private readonly List<int> input = [.. input];
+    private readonly int expected = expected;
+
+    public string Title
+    {
+      get { return title; }
+    }
+    public List<int> Input
+    {
+      get { return input; }
+    }
+    public int Expected
+    {
+      get { return expected; }
+    }
   }
 
   private List<MinimumAbsoluteDifferenceInAnArrayTestCase> testCases { get; set; } = default!;
@@ -29,15 +42,15 @@ public void testMinimumAbsoluteDifferenceInAnArray()
 
     foreach (MinimumAbsoluteDifferenceInAnArrayTestCase test in testCases)
     {
-      result = MinimumAbsoluteDifferenceInAnArray.minimumAbsoluteDifference(test.input);
+      result = MinimumAbsoluteDifferenceInAnArray.minimumAbsoluteDifference(test.Input);
       Assert.AreEqual(
-        test.expected,
+        test.Expected,
         result,
         string.Format(
           System.Globalization.CultureInfo.InvariantCulture,
           "minimumAbsoluteDifference({0}) => must be: {1}",
-          test.input.ToString(),
-          test.expected
+          test.Input.ToString(),
+          test.Expected
         )
       );
     }