Merge pull request #208 from sir-gon/feature/refactor

Feature/refactor

Author: sir-gon

.editorconfig

@@ -57,6 +57,26 @@ dotnet_naming_rule.all_methods_must_be_camel_case.style    = camel_case_style
 dotnet_naming_rule.all_methods_must_be_camel_case.severity = warning
 
 # Due clean code suggestion
+
+# CA1034: Los tipos anidados no deben ser visibles
+dotnet_diagnostic.CA1034.severity = none
+
+# CA1002: No exponer listas genéricas
+dotnet_diagnostic.CA1002.severity = none
+
+# CA1707: Los identificadores no deben contener caracteres de subrayado
+dotnet_diagnostic.CA1707.severity = none
+
+# CA1308: Normalizar las cadenas en mayúsculas
+dotnet_diagnostic.CA1308.severity = none
+
+
 [*.{cs,vb}]
+# Default severity for analyzer diagnostics with category 'Style'
+dotnet_analyzer_diagnostic.category-Style.severity = none
+
 dotnet_diagnostic.IDE0054.severity = none
 dotnet_diagnostic.IDE0074.severity = none
+
+# CA1515: Consider making public types internal
+dotnet_diagnostic.CA1515.severity = none

.github/workflows/dotnet-lint.yml

@@ -0,0 +1,38 @@
+# yamllint disable rule:line-length
+# This workflow will build a .NET project
+# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-net
+# yamllint enable rule:line-length
+
+---
+name: dotNET Tests
+
+on: # yamllint disable-line rule:truthy
+  push:
+    branches: ["main"]
+  pull_request:
+    # The branches below must be a subset of the branches above
+    branches: ["main"]
+  workflow_dispatch:
+
+jobs:
+  lint:
+    name: "Run LINT"
+    strategy:
+      fail-fast: false
+      matrix:
+        os: ["windows-2022", "windows-2025", "ubuntu-24.04", "macos-14"]
+        dotnet-version: [8.x, 9.x]
+    runs-on: ${{ matrix.os }}
+    steps:
+      - uses: actions/checkout@v4
+      - name: Setup .NET ${{ matrix.dotnet-version }}
+        uses: actions/setup-dotnet@v4
+        with:
+          dotnet-version: ${{ matrix.dotnet-version }}
+      - name: Tooling check
+        run: >
+          dotnet --version
+      - name: Restore dependencies
+        run: dotnet restore
+      - name: Lint (codestyle)
+        run: dotnet format --verify-no-changes --verbosity normal

.github/workflows/dotnet.yml renamed to .github/workflows/dotnet-test.yml

@@ -36,8 +36,6 @@ jobs:
         run: dotnet restore
       - name: Build
         run: dotnet build --no-restore
-      - name: Lint (codestyle)
-        run: dotnet format --verify-no-changes --verbosity normal
       - name: Test
         run: >
           dotnet test --no-build

src/algorithm_exercises_csharp/Hello.cs

@@ -4,12 +4,9 @@ namespace algorithm_exercises_csharp;
 
 public class HelloWorld
 {
-  const string __message = "Hello World!";
+  private readonly string __message = "Hello World!";
 
-  [ExcludeFromCodeCoverage]
-  protected HelloWorld() { }
-
-  public static string hello()
+  public string hello()
   {
     return __message;
   }

src/algorithm_exercises_csharp/algorithm_exercises_csharp.csproj

@@ -8,11 +8,13 @@
 
     <GenerateRuntimeConfigurationFiles>true</GenerateRuntimeConfigurationFiles>
 
-    <!-- Static Analysis -->
+    <!-- Code analysis. -->
     <EnableNETAnalyzers>true</EnableNETAnalyzers>
     <AnalysisLevel>latest</AnalysisLevel>
+    <AnalysisMode>All</AnalysisMode>
+    <!-- <TreatWarningsAsErrors>true</TreatWarningsAsErrors> -->
+    <!-- <CodeAnalysisTreatWarningsAsErrors>true</CodeAnalysisTreatWarningsAsErrors> -->
     <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
-    <CodeAnalysisTreatWarningsAsErrors>false</CodeAnalysisTreatWarningsAsErrors>
 
   </PropertyGroup>
 

src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/arrays/ArraysLeftRotation.cs

@@ -4,18 +4,17 @@ namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.arrays
 
 using System.Diagnostics.CodeAnalysis;
 
-public class ArraysLeftRotation
+public static class ArraysLeftRotation
 {
-  [ExcludeFromCodeCoverage]
-  protected ArraysLeftRotation() { }
-
   public const int FIRST_POSITION = 0;
 
   /**
    * In favor of increasing performance, this implementation mutates the input list.
    */
   public static List<int> rotLeftOne(List<int> input)
   {
+    ArgumentNullException.ThrowIfNull(input);
+
     int first = input[FIRST_POSITION];
     input.RemoveAt(FIRST_POSITION);
     input.Add(first);
@@ -28,6 +27,8 @@ public static List<int> rotLeftOne(List<int> input)
    */
   public static List<int> rotLeft(List<int> input, int d)
   {
+    ArgumentNullException.ThrowIfNull(input);
+
     // Clone the list
     List<int> output = input.GetRange(FIRST_POSITION, input.Count);
 

src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/arrays/CrushBruteForce.cs

@@ -5,15 +5,14 @@ namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.arrays
 
 using System.Diagnostics.CodeAnalysis;
 
-public class CrushBruteForce
+public static class CrushBruteForce
 {
-  [ExcludeFromCodeCoverage]
-  protected CrushBruteForce() { }
-
   private const int INITIALIZER = 0;
 
   public static long arrayManipulation(int n, List<List<int>> queries)
   {
+    ArgumentNullException.ThrowIfNull(queries);
+
     // why adding 1?
     //   first slot to adjust 1-based index and
     int[] result = new int[n + 1];

src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/arrays/CrushOptimized.cs

@@ -5,16 +5,15 @@ namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.arrays
 
 using System.Diagnostics.CodeAnalysis;
 
-public class CrushOptimized
+public static class CrushOptimized
 {
-  [ExcludeFromCodeCoverage]
-  private CrushOptimized() { }
-
   /**
   // arrayManipulation.
    */
   public static long arrayManipulation(int n, List<List<int>> queries)
   {
+    ArgumentNullException.ThrowIfNull(queries);
+
     // why adding 2?
     //   first slot to adjust 1-based index and
     //   last slot for storing accumSum result

src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/arrays/NewYearChaos.cs

@@ -2,20 +2,17 @@
 
 namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.arrays;
 
-using System.Diagnostics.CodeAnalysis;
-
-public class NewYearChaos
+public static class NewYearChaos
 {
-  [ExcludeFromCodeCoverage]
-  protected NewYearChaos() { }
-
-  public const String TOO_CHAOTIC_ERROR = "Too chaotic";
+  public const string TOO_CHAOTIC_ERROR = "Too chaotic";
 
   /**
    * minimumBribesCalculate.
    */
   public static int minimumBribesCalculate(List<int> q)
   {
+    ArgumentNullException.ThrowIfNull(q);
+
     int bribes = 0;
     int i = 0;
 
@@ -46,16 +43,16 @@ public static int minimumBribesCalculate(List<int> q)
   /**
    * minimumBribes.
    */
-  public static String minimumBribesText(List<int> q)
+  public static string minimumBribesText(List<int> q)
   {
     try
     {
       int bribes = minimumBribesCalculate(q);
-      return String.Format("{0}", bribes);
+      return string.Format(System.Globalization.CultureInfo.InvariantCulture, "{0}", bribes);
     }
     catch (InvalidOperationException e)
     {
-      return String.Format(e.Message);
+      return string.Format(System.Globalization.CultureInfo.InvariantCulture, "{0}", e.Message);
     }
   }
 
@@ -64,6 +61,6 @@ public static String minimumBribesText(List<int> q)
    */
   public static void minimumBribes(List<int> q)
   {
-    Console.WriteLine("{0}", minimumBribesText(q));
+    Console.WriteLine(minimumBribesText(q));
   }
 }

src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/arrays/TwoDArray.cs

@@ -4,11 +4,8 @@ namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.arrays
 
 using System.Diagnostics.CodeAnalysis;
 
-public class TwoDArray
+public static class TwoDArray
 {
-  [ExcludeFromCodeCoverage]
-  protected TwoDArray() { }
-
   private static List<int> getHourGlass(List<List<int>> arr, int positionX, int positionY)
   {
     List<int> result = [];
@@ -31,6 +28,8 @@ private static List<int> getHourGlass(List<List<int>> arr, int positionX, int po
 
   public static int hourglassSum(List<List<int>> arr)
   {
+    ArgumentNullException.ThrowIfNull(arr);
+
     int matrixSize = arr.Count;
 
     int matrixStartIndex = 1;

src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/CountTriplets.cs

@@ -4,16 +4,14 @@
 
 namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.dictionaries_and_hashmaps;
 
-using System.Diagnostics.CodeAnalysis;
 using System.Collections.Generic;
 
-public class CountTriplets
+public static class CountTriplets
 {
-  [ExcludeFromCodeCoverage]
-  protected CountTriplets() { }
-
   public static long countTriplets(List<long> arr, long r)
   {
+    ArgumentNullException.ThrowIfNull(arr);
+
     Dictionary<long, long> aCounter = [];
     Dictionary<long, long> bCounter = [];
     long triplets = 0L;

src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/CountTripletsBruteForce.cs

@@ -5,13 +5,12 @@ namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.dictio
 using System.Diagnostics.CodeAnalysis;
 using System.Collections.Generic;
 
-public class CountTripletsBruteForce
+public static class CountTripletsBruteForce
 {
-  [ExcludeFromCodeCoverage]
-  protected CountTripletsBruteForce() { }
-
   public static long countTriplets(List<long> arr, long r)
   {
+    ArgumentNullException.ThrowIfNull(arr);
+
     long size = arr.Count;
     long counter = 0L;
 

src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/FrequencyQueries.cs

@@ -13,14 +13,14 @@ private FrequencyQueries()
     reset();
   }
 
-  private static readonly long __INITIAL__ = 1L;
+  private const long __INITIAL__ = 1L;
 
   private const int __INSERT__ = 1;
   private const int __DELETE__ = 2;
   private const int __SELECT__ = 3;
 
-  private static readonly int __NOT_FOUND__ = 0;
-  private static readonly int __FOUND__ = 1;
+  private const int __NOT_FOUND__ = 0;
+  private const int __FOUND__ = 1;
 
   readonly Dictionary<long, long> valueFreqs = [];
   readonly Dictionary<long, List<long>> freqDictionary = [];
@@ -116,6 +116,8 @@ void select(long value)
    */
   public static List<int> freqQuery(List<List<int>> queries)
   {
+    ArgumentNullException.ThrowIfNull(queries);
+
     FrequencyQueries fq = new();
 
     foreach (List<int> query in queries)

src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/RansomNote.cs

@@ -5,25 +5,33 @@ namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.dictio
 using System.Diagnostics.CodeAnalysis;
 using System.Collections.Generic;
 
-public class RansomNote
+public static class RansomNote
 {
-  [ExcludeFromCodeCoverage]
-  protected RansomNote() { }
-
   public class InvalidValueException : Exception
   {
     // constructor for the InvalidAgeException class
     public InvalidValueException(string msg)
     {
       Console.WriteLine(msg);
     }
+
+    public InvalidValueException()
+    {
+    }
+
+    public InvalidValueException(string message, Exception innerException) : base(message, innerException)
+    {
+    }
   }
 
-  private static readonly string __YES__ = "Yes";
-  private static readonly string __NO__ = "No";
+  private const string __YES__ = "Yes";
+  private const string __NO__ = "No";
 
   public static bool checkMagazineCompute(List<string> magazine, List<string> note)
   {
+    ArgumentNullException.ThrowIfNull(magazine);
+    ArgumentNullException.ThrowIfNull(note);
+
     Dictionary<string, int> dictionary = [];
 
     foreach (string word in magazine)
@@ -45,7 +53,7 @@ public static bool checkMagazineCompute(List<string> magazine, List<string> note
           throw new InvalidValueException("Value can't go below 0");
         }
       }
-      catch
+      catch (InvalidValueException)
       {
         return false;
       }

src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/SherlockAndAnagrams.cs

@@ -5,11 +5,8 @@ namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.dictio
 using System.Diagnostics.CodeAnalysis;
 using System.Numerics;
 
-public class SherlockAndAnagrams
+public static class SherlockAndAnagrams
 {
-  [ExcludeFromCodeCoverage]
-  protected SherlockAndAnagrams() { }
-
   /**
    * factorial().
    */
@@ -26,6 +23,8 @@ public static BigInteger factorial(int number)
 
   public static int sherlockAndAnagrams(string s)
   {
+    ArgumentException.ThrowIfNullOrEmpty(s);
+
     Dictionary<string, List<string>> candidates = [];
 
     int size = s.Length;