Skip to content

Commit 5d21b81

Browse files
authored
fix: EventEmitter on method signatures to use spread syntax (#2200)
1 parent a0e0e2f commit 5d21b81

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

promise.d.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ export interface PoolCluster extends EventEmitter {
115115

116116
of(pattern: string, selector?: string): PoolNamespace;
117117

118-
on(event: string, listener: (args: any[]) => void): this;
118+
on(event: string, listener: (...args: any[]) => void): this;
119119
on(event: 'remove', listener: (nodeId: number) => void): this;
120120
on(event: 'warn', listener: (err: Error) => void): this;
121121
}

typings/mysql/lib/Connection.d.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,7 @@ declare class Connection extends QueryableBase(ExecutableBase(EventEmitter)) {
357357

358358
format(sql: string, values?: any | any[] | { [param: string]: any }): string;
359359

360-
on(event: string, listener: (args: any[]) => void): this;
360+
on(event: string, listener: (...args: any[]) => void): this;
361361

362362
rollback(callback: (err: QueryError | null) => void): void;
363363

typings/mysql/lib/Pool.d.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ declare class Pool extends QueryableBase(ExecutableBase(EventEmitter)) {
6363
callback?: (err: NodeJS.ErrnoException | null, ...args: any[]) => any
6464
): void;
6565

66-
on(event: string, listener: (args: any[]) => void): this;
66+
on(event: string, listener: (...args: any[]) => void): this;
6767
on(event: 'connection', listener: (connection: PoolConnection) => any): this;
6868
on(event: 'acquire', listener: (connection: PoolConnection) => any): this;
6969
on(event: 'release', listener: (connection: PoolConnection) => any): this;

typings/mysql/lib/PoolCluster.d.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ declare class PoolCluster extends EventEmitter {
7878

7979
of(pattern: string, selector?: string): PoolNamespace;
8080

81-
on(event: string, listener: (args: any[]) => void): this;
81+
on(event: string, listener: (...args: any[]) => void): this;
8282
on(event: 'remove', listener: (nodeId: number) => void): this;
8383
on(event: 'warn', listener: (err: Error) => void): this;
8484
}

typings/mysql/lib/protocol/sequences/Query.d.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ declare class Query extends Sequence {
133133
*/
134134
stream(options?: StreamOptions): Readable;
135135

136-
on(event: string, listener: (args: any[]) => void): this;
136+
on(event: string, listener: (...args: any[]) => void): this;
137137
on(event: 'error', listener: (err: QueryError) => any): this;
138138
on(
139139
event: 'fields',

0 commit comments

Comments
 (0)