Skip to content
This repository was archived by the owner on Apr 16, 2019. It is now read-only.

Webpack 4 help - using in conjunction with mini-css-extract-plugin #36

Closed
iongion opened this issue Mar 9, 2018 · 2 comments
Closed

Comments

@iongion
Copy link

iongion commented Mar 9, 2018

Webpack 4 has issues with the extract text plugin
https://github.com/webpack-contrib/extract-text-webpack-plugin/issues

So now, the recommended solution is to use mini-css-extract-plugin, but that one does not work with the hot reload.

I have attached a zip with sample use, I do not know where the issues lies, in css-hot-loader or mini-css-extract-plugin

react-demo.zip

@iongion iongion changed the title Webpack 4 help - using in conjunction with mini-css-extract-plugin Webpack 4 help - using in conjunction with mini-css-extract-plugin Mar 9, 2018
@iongion
Copy link
Author

iongion commented Mar 9, 2018

Feel free to close this issue if you notice that the fix really needs to be applied in the mini-css-extract-plugin project.

@shepherdwind
Copy link
Owner

This problem should fixed in mini-css-extract-plugin. I tried mini-css-extract-plugin with css-hot-loader, when css changed, css-hot-loader will reload css ,but this css file not changed.

So, I remove the css-hot-loader plugin, then change css file, reload the css file manual. But The css context not change too. So this is not the problem of css-hot-loader.

I think the issue case by webpack-contrib/mini-css-extract-plugin#23 .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants