Skip to content

Cannot specify option for the plugin's installation of the project's modules #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HyperBrain opened this issue Feb 14, 2017 · 2 comments

Comments

@HyperBrain
Copy link
Member

I have a problem, that some of my project dependencies reference optional dependencies, that I have to disable when doing an npm install by specifying the --no-optional switch (e.g. fsevents on Windows).

The npm install --no-optional works in the SLS project directory, but when doing a serverless webpack, the plugin seems to do a completely separate install of the modules and hangs, because the --no-optional switch was not given to the npm command.

I see two possible solution for that: Either provide some means to add npm options on the command line/config or copy the node modules from the node_modules folder instead of doing it completely separate.

@HyperBrain
Copy link
Member Author

I created an improvement issue at npm-programmatic for support of arbitrary options on their end. As soon as this has been implemented, the webpack plugin could make use of it and provide the requested feature.
Manak/npm-programmatic#9

@HyperBrain
Copy link
Member Author

With npm 5 and the completely reworked packaging in the plugin, this is not really needed anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant