-
Notifications
You must be signed in to change notification settings - Fork 59
2.13: re-enable Scala.js tests #674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Sébastien, I'll need your guidance here, I don't understand the failures. let us know if we can answer any questions about what's changed in 2.13, and hopefully we'll meet in the middle somewhere. |
I assume it will be reproducible outside of dbuild if you just use the latest 2.13 nightly. if not let me know |
Yes, the 2.13 nightly reproduced the bug. This is an easy one: it's because the fix for scala/bug#10512 hasn't reached your 2.13.x branch yet, but we already have tests for it. The tests are disabled in 2.12.{0-4} and 2.13.0-M2, because those versions are known to be defective wrt. it, but "2.13.0-pre-whatever" does not qualify to exclude the test. In fact, So the fix for this one is just that you forward merge 2.12.x into 2.13.x. |
aha. okay, I think at our team meeting yesterday someone said they'd be doing that shortly (in the next few days) |
If I manually disable that test, both |
update: I merged 2.12.x onto 2.13.x, but there isn't a new nightly build yet |
new nightly: 2.13.0-pre-79e5101 trying to re-enable the test suite uncovered a regression in (I think) constant-folding: scala/scala-dev#465 |
current status: we're on the new collections now, so scala-js has worse problems now :-) the current config file has tests re-enabled (so I'm closing this ticket), but the run doesn't even get that far, currently. scala-js-stubs works, which is the part downstream projects need. |
as per d44382b
cc @sjrd
The text was updated successfully, but these errors were encountered: