Skip to content

Commit fc24fec

Browse files
authored
Use pubspec_parse dependency equality (#2254)
1 parent 5121eb1 commit fc24fec

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

pubspec.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ dev_dependencies:
4848
lints: ">=2.0.0 <5.0.0"
4949
protoc_plugin: ">=20.0.0 <22.0.0"
5050
pub_api_client: ^2.1.1
51-
pubspec_parse: ^1.0.0
51+
pubspec_parse: ^1.3.0
5252
test: ^1.16.7
5353
test_descriptor: ^2.0.0
5454
test_process: ^2.0.0

test/double_check_test.dart

+2-8
Original file line numberDiff line numberDiff line change
@@ -116,14 +116,8 @@ void main() {
116116
});
117117

118118
test("matches dartdoc version", () {
119-
// TODO(nweiz): Just use equals() once dart-lang/pubspec_parse#127 lands
120-
// and is released.
121-
var sassDep = sassPubspec.devDependencies["dartdoc"];
122-
var pkgDep = pkgPubspec.devDependencies["dartdoc"];
123-
expect(pkgDep, isA<HostedDependency>());
124-
expect(sassDep, isA<HostedDependency>());
125-
expect((pkgDep as HostedDependency).version,
126-
equals((sassDep as HostedDependency).version));
119+
expect(sassPubspec.devDependencies["dartdoc"],
120+
equals(pkgPubspec.devDependencies["dartdoc"]));
127121
});
128122
});
129123
}

0 commit comments

Comments
 (0)