PR feedback

Author: Jamesbarford

Cargo.toml

@@ -2,14 +2,6 @@
 resolver = "1"
 members = [
   "crates/*",
-  "examples"
-  "crates/stdarch-verify",
-  "crates/core_arch",
-  "crates/std_detect",
-  "crates/stdarch-gen-loongarch",
-  "crates/stdarch-gen2",
-  "crates/intrinsic-test",
-  "examples/"
 ]
 exclude = [
   "crates/wasm-assert-instr-tests"

crates/core_arch/src/arm_shared/neon/mod.rs

@@ -11,89 +11,33 @@ use crate::{core_arch::simd::*, hint::unreachable_unchecked, intrinsics::simd::*
 #[cfg(test)]
 use stdarch_test::assert_instr;
 
-#[unstable(feature = "stdarch_internal", issue = "none")]
 pub(crate) trait AsUnsigned {
     type Unsigned: ?Sized;
-    unsafe fn as_unsigned(self) -> Self::Unsigned;
+    fn as_unsigned(self) -> Self::Unsigned;
 }
 
-#[unstable(feature = "stdarch_internal", issue = "none")]
 pub(crate) trait AsSigned {
     type Signed: ?Sized;
-    unsafe fn as_signed(self) -> Self::Signed;
-}
-
-macro_rules! impl_sign_conversions {
-    ($(($signed:ty, $unsigned:ty))*) => ($(
-        #[cfg_attr(
-            not(target_arch = "arm"),
-            stable(feature = "neon_intrinsics", since = "1.59.0")
-        )]
-        #[cfg_attr(
-            target_arch = "arm",
-            unstable(feature = "stdarch_arm_neon_intrinsics", issue = "111800")
-        )]
-        impl AsUnsigned for $signed {
-            type Unsigned = $unsigned;
-
-            #[inline]
-            unsafe fn as_unsigned(self) -> $unsigned {
-                crate::mem::transmute(self)
-            }
-        }
-
-        #[cfg_attr(
-            not(target_arch = "arm"),
-            stable(feature = "neon_intrinsics", since = "1.59.0")
-        )]
-        #[cfg_attr(
-            target_arch = "arm",
-            unstable(feature = "stdarch_arm_neon_intrinsics", issue = "111800")
-        )]
-        impl AsSigned for $unsigned {
-            type Signed = $signed;
-
-            #[inline]
-            unsafe fn as_signed(self) -> $signed {
-                crate::mem::transmute(self)
-            }
-        }
-    )*)
+    fn as_signed(self) -> Self::Signed;
 }
 
 macro_rules! impl_sign_conversions_neon {
     ($(($signed:ty, $unsigned:ty))*) => ($(
-        #[cfg_attr(
-            not(target_arch = "arm"),
-            stable(feature = "neon_intrinsics", since = "1.59.0")
-        )]
-        #[cfg_attr(
-            target_arch = "arm",
-            unstable(feature = "stdarch_arm_neon_intrinsics", issue = "111800")
-        )]
         impl AsUnsigned for $signed {
             type Unsigned = $unsigned;
 
             #[inline]
-            unsafe fn as_unsigned(self) -> $unsigned {
-                crate::mem::transmute(self)
+            fn as_unsigned(self) -> $unsigned {
+                unsafe { transmute(self) }
             }
         }
 
-        #[cfg_attr(
-            not(target_arch = "arm"),
-            stable(feature = "neon_intrinsics", since = "1.59.0")
-        )]
-        #[cfg_attr(
-            target_arch = "arm",
-            unstable(feature = "stdarch_arm_neon_intrinsics", issue = "111800")
-        )]
         impl AsSigned for $unsigned {
             type Signed = $signed;
 
             #[inline]
-            unsafe fn as_signed(self) -> $signed {
-                crate::mem::transmute(self)
+            fn as_signed(self) -> $signed {
+                unsafe { transmute(self) }
             }
         }
     )*)
@@ -1121,7 +1065,7 @@ pub struct poly64x2x4_t(
     pub poly64x2_t,
 );
 
-impl_sign_conversions! {
+impl_sign_conversions_neon! {
     (i8, u8)
     (i16, u16)
     (i32, u32)
@@ -1150,9 +1094,6 @@ impl_sign_conversions! {
     (uint64x2_t, int64x2_t)
     (uint8x16_t, int8x16_t)
     (uint8x8_t, int8x8_t)
-}
-
-impl_sign_conversions_neon! {
     (int16x4x2_t, uint16x4x2_t)
     (int16x4x3_t, uint16x4x3_t)
     (int16x4x4_t, uint16x4x4_t)

crates/stdarch-gen2/Cargo.toml renamed to crates/stdarch-gen-arm/Cargo.toml

@@ -116,29 +116,25 @@ fn functions(input: TokenStream, dirs: &[&str]) -> TokenStream {
                 quote! { None }
             };
 
-            let required_const = find_required_const("rustc_args_required_const", &f.attrs);
             let mut const_generics_indices =
                 find_required_const("rustc_legacy_const_generics", &f.attrs);
-            if !required_const.is_empty() && !const_generics_indices.is_empty() {
+            if !const_generics_indices.is_empty() {
                 panic!(
                     "Can't have both #[rustc_args_required_const] and \
                      #[rustc_legacy_const_generics]"
                 );
             }
 
-            // Newer intrinsics don't have legacy support - assume they belong at the end of the argument list
-            if required_const.is_empty() && const_generics_indices.is_empty() {
+            // Newer intrinsics don't have legacy support:
+            // Thus assume they belong at the end of the argument list
+            if const_generics_indices.is_empty() {
                 const_generics_indices =
                     (arguments.len()..(arguments.len() + const_arguments.len())).collect();
             }
 
-            // The list of required consts, used to verify the arguments, comes from either the
-            // `rustc_args_required_const` or the `rustc_legacy_const_generics` attribute.
-            let required_const = if required_const.is_empty() {
-                const_generics_indices.clone()
-            } else {
-                required_const
-            };
+            // The list of required consts, used to verify the arguments, comes
+            // from the `rustc_legacy_const_generics` attribute.
+            let required_const = const_generics_indices.clone();
 
             const_generics_indices.sort();
             for (idx, ty) in const_generics_indices