Skip to content

rustfmt converts properly fit function call to vertical aligment #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
srinivasreddy opened this issue Sep 26, 2016 · 2 comments
Closed

Comments

@srinivasreddy
Copy link
Contributor

srinivasreddy commented Sep 26, 2016

-        Ok(self.confirm_method(span, self_expr, call_expr, self_ty, pick, supplied_method_types))
+        Ok(self.confirm_method(span,
+                               self_expr,
+                               call_expr,
+                               self_ty,
+                               pick,
+                               supplied_method_types))

https://github.com/rust-lang/rust/pull/36736/files/1d1168ccea6ee1ede476cefb424c384ba7904bb5#diff-d66943f8e54938955ce02ba6b02eece3L138

@nrc
Copy link
Member

nrc commented Oct 11, 2016

I think we might just have a cutoff at which we use vertical formatting even if we don't hit the width limit, in which case this is not a bug.

@nrc
Copy link
Member

nrc commented Oct 11, 2016

Yeah, fn_call_width: https://github.com/rust-lang-nursery/rustfmt/blob/master/src/config.rs#L343

Style team might decide to lose this, but closing this as intended behaviour for now.

@nrc nrc closed this as completed Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants