-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Clean up submodule checkout scripts #98439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This was used long ago in Travis/Appveyor, but is no longer used.
The code using `fetch_github_commit_archive` was removed in rust-lang#72937.
checkout-submodules.sh is no longer serving any purpose other than to run init_repo.
(rust-highfive has picked a reviewer for you, use r? to override) |
@bors r+ rollup=iffy |
📌 Commit 124557c has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (495b216): comparison url. Instruction count
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Footnotes |
Clearly not an actual regression, or at least not one we can do anything about; this wouldn't have affected generated code at all in my expectation. |
This is just some small cleanup: