Skip to content

[rustdoc] Remove object methods coming from trait impls in search results? #71144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
GuillaumeGomez opened this issue Apr 14, 2020 · 3 comments
Open

[rustdoc] Remove object methods coming from trait impls in search results? #71144

GuillaumeGomez opened this issue Apr 14, 2020 · 3 comments
Labels
A-dyn-trait Area: trait objects, vtable layout A-rustdoc-search Area: Rustdoc's search feature C-discussion Category: Discussion or questions that doesn't represent real issues. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@GuillaumeGomez
Copy link
Member

Currently, if an object A implements a trait B, the search will show both A::whatever and B::whatever. I think this might be a bit too much. Removing this would in addition makes the search-index file ligher.

What do you think @rust-lang/rustdoc ?
@GuillaumeGomez GuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Apr 14, 2020
@GuillaumeGomez GuillaumeGomez self-assigned this Apr 14, 2020
@kinnison
Copy link
Contributor

Is there ever a case where traits are the primary interface to a type? In that context it probably makes sense to include A::whatever in the index.

@GuillaumeGomez
Copy link
Member Author

I think it makes sense most of the time. I'm just exploring new leads to reduce search-index.js size. At some time, we might convert it to wasm. To be tested as well.

@GuillaumeGomez GuillaumeGomez mentioned this issue Apr 16, 2020
Closed
@kinnison
Copy link
Contributor

Could we load the search index in the background instead?

@GuillaumeGomez GuillaumeGomez removed their assignment Apr 24, 2023
@fmease fmease added C-discussion Category: Discussion or questions that doesn't represent real issues. A-rustdoc-search Area: Rustdoc's search feature A-dyn-trait Area: trait objects, vtable layout labels Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-dyn-trait Area: trait objects, vtable layout A-rustdoc-search Area: Rustdoc's search feature C-discussion Category: Discussion or questions that doesn't represent real issues. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kinnison @GuillaumeGomez @fmease