Consider renaming .connect() to .join()

[barosl]

SliceConcatExt has a method named .connect(), which is similar to .join() in other languages. I don't have any specific numbers, but "join" seems to be used more widely.

We could not use "join" because it was previously a keyword. Now it isn't, and SliceConcatExt is currently marked as unstable, so how about renaming the method to a more popular name?

One blocker is that SliceConcatExt is already exported to the prelude. So, although it is technically unstable, the change will still break the currently accepted beta-compatible code.

Will this require a RFC?

cc http://www.reddit.com/r/rust/comments/336rj3/whats_the_best_way_to_join_strings_with_a_space/

[steveklabnik]

/cc @aturon

[frewsxcv]

What other languages use:

• Ruby: join
• Python: join
• JavaScript: join
• Go: Join

[petrochenkov]

• C++ (boost): join
• C#: Join
• Java 8: join
• Perl: join

[bombless]

+1, we should do it in 1.1-nighty

[aturon]

Interesting! I'd always found the connect name intuitive, but the precedent here seems quite strong.

It'd be good for this to go through an RFC. We can't do an outright renaming at this point, but we could deprecate the old name and introduce a new one if there's strong enough consensus. (The fact that the methods of this trait are already stable reflects a commitment to the existing names; the lack of stability of the trait is more about how we provide these impls in std.)

[frewsxcv]

rust-lang/rfcs#1102 merged, this can probably be closed?

[alexcrichton]

Indeed!