Skip to content

Linker errors should save command to disk #114293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
estebank opened this issue Jul 31, 2023 · 2 comments
Closed

Linker errors should save command to disk #114293

estebank opened this issue Jul 31, 2023 · 2 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints D-papercut Diagnostics: An error or lint that needs small tweaks. D-verbose Diagnostics: Too much output caused by a single piece of incorrect code. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@estebank
Copy link
Contributor

On linker errors (and any other where we execute a command), we currently print the whole command line argument list in a note. We should instead store these to disk in the same way that we do for long types.
@estebank estebank added A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. D-papercut Diagnostics: An error or lint that needs small tweaks. D-verbose Diagnostics: Too much output caused by a single piece of incorrect code. labels Jul 31, 2023
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jul 31, 2023
@compiler-errors compiler-errors removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jul 31, 2023
@compiler-errors
Copy link
Member

If this functionality is added, it should respect -Zwrite-long-types-to-disk=no (and perhaps that flag needs to have its name generalized) or have some other opt-out for UI tests.

@estebank
Copy link
Contributor Author

estebank commented Aug 2, 2023

Clearly I'm nothing if not consistent.

Dupe #110763

@estebank estebank closed this as completed Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints D-papercut Diagnostics: An error or lint that needs small tweaks. D-verbose Diagnostics: Too much output caused by a single piece of incorrect code. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@estebank @compiler-errors @rustbot