Skip to content

Commit f051196

Browse files
committed
auto merge of #8909 : lkuper/rust/default-methods-refactor, r=alexcrichton
(cc: #3227) Parts I'm unsure about and would like a reviewer to look at are: * `pub trait GenericPath : Clone + Eq + ToStr` -- is this the done thing? I've never done trait inheritance before, let alone from multiple traits, but it seemed to be necessary to be able to call all the methods we have to be able to call on `self`. * changing the argument of `components` from `self` to `&self`, and having it return `self.components.clone()` instead of `self.components`; this was necessary to avoid move errors, but I'm not sure if it's the right thing. (The default methods impls now all have to call `self.components()` instead of just referencing the field `self.components`.)
2 parents a980f28 + 59291eb commit f051196

File tree

1 file changed

+156
-234
lines changed

1 file changed

+156
-234
lines changed

0 commit comments

Comments
 (0)