Skip to content

Commit c011828

Browse files
committed
Disable both reproducible-build tests for crate-type=bin
These tests fail on Windows, as the build is not deterministic there for bin targets. Issue #88982 is filed for this problem.
1 parent 4933be9 commit c011828

File tree

3 files changed

+5
-14
lines changed

3 files changed

+5
-14
lines changed

.github/workflows/ci.yml

-5
Original file line numberDiff line numberDiff line change
@@ -534,11 +534,6 @@ jobs:
534534
strategy:
535535
matrix:
536536
include:
537-
- name: x86_64-msvc-1
538-
env:
539-
RUST_CONFIGURE_ARGS: "--build=x86_64-pc-windows-msvc --enable-profiler"
540-
SCRIPT: make ci-subset-1
541-
os: windows-latest-xl
542537
- name: dist-x86_64-linux
543538
os: ubuntu-latest-xl
544539
env: {}

src/ci/github-actions/ci.yml

-5
Original file line numberDiff line numberDiff line change
@@ -668,11 +668,6 @@ jobs:
668668
strategy:
669669
matrix:
670670
include:
671-
- name: x86_64-msvc-1
672-
env:
673-
RUST_CONFIGURE_ARGS: --build=x86_64-pc-windows-msvc --enable-profiler
674-
SCRIPT: make ci-subset-1
675-
<<: *job-windows-xl
676671
- *dist-x86_64-linux
677672

678673
master:

src/test/run-make-fulldeps/reproducible-build/Makefile

+5-4
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,16 @@ all: \
99
opt \
1010
link_paths \
1111
remap_paths \
12-
different_source_dirs_bin \
1312
different_source_dirs_rlib \
1413
remap_cwd_rlib \
1514
remap_cwd_to_empty \
1615
extern_flags
1716

18-
# TODO: Deterministic builds of `bin` crate types are not deterministic with
19-
# debuginfo=2 on Windows.
20-
# See https://github.com/rust-lang/rust/pull/87320#issuecomment-920105533
17+
# TODO: Builds of `bin` crate types are not deterministic with debuginfo=2 on
18+
# Windows.
19+
# See: https://github.com/rust-lang/rust/pull/87320#issuecomment-920105533
20+
# Issue: https://github.com/rust-lang/rust/issues/88982
21+
#
2122
# different_source_dirs_bin \
2223
# remap_cwd_bin \
2324

0 commit comments

Comments
 (0)