Don't pass -pie to linker on windows targets.

luqmana · luqmana · commit ac5fd90d8223 · 2021-05-18T03:57:53.000-07:00
diff --git a/compiler/rustc_codegen_ssa/src/back/linker.rs b/compiler/rustc_codegen_ssa/src/back/linker.rs
@@ -281,8 +281,11 @@ impl<'a> Linker for GccLinker<'a> {
                 }
             }
             LinkOutputKind::DynamicPicExe => {
-                // `-pie` works for both gcc wrapper and ld.
-                self.cmd.arg("-pie");
+                // noop on windows w/ gcc & ld, error w/ lld
+                if !self.sess.target.is_like_windows {
+                    // `-pie` works for both gcc wrapper and ld.
+                    self.cmd.arg("-pie");
+                }
             }
             LinkOutputKind::StaticNoPicExe => {
                 // `-static` works for both gcc wrapper and ld.

Original file line number	Diff line number	Diff line change
`@@ -281,8 +281,11 @@ impl<'a> Linker for GccLinker<'a> {`
`281`	`281`	`}`
`282`	`282`	`}`
`283`	`283`	`LinkOutputKind::DynamicPicExe => {`
`284`		- // `-pie` works for both gcc wrapper and ld.
`285`		`- self.cmd.arg("-pie");`
	`284`	`+ // noop on windows w/ gcc & ld, error w/ lld`
	`285`	`+ if !self.sess.target.is_like_windows {`
	`286`	+ // `-pie` works for both gcc wrapper and ld.
	`287`	`+ self.cmd.arg("-pie");`
	`288`	`+ }`
`286`	`289`	`}`
`287`	`290`	`LinkOutputKind::StaticNoPicExe => {`
`288`	`291`	// `-static` works for both gcc wrapper and ld.