Skip to content

Commit 6f95990

Browse files
committed
Auto merge of #74593 - ehuss:update-beta-cargo, r=Mark-Simulacrum
[beta] Update cargo 2 commits in 4f74d9b2a771c58b7ef4906b2668afd075bc8081..149022b1d8f382e69c1616f6a46b69ebf59e2dea 2020-07-08 17:13:00 +0000 to 2020-07-17 16:39:39 -0400 - [beta] Revert "Improve support for non-`master` main branches" (rust-lang/cargo#8503) - [beta] Avoid colliding with older Cargo fingerprint changes (rust-lang/cargo#8488)
2 parents e51b714 + 85f1370 commit 6f95990

File tree

5 files changed

+8
-38
lines changed

5 files changed

+8
-38
lines changed

.github/workflows/ci.yml

+2-5
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ name: CI
2626
- "**"
2727
defaults:
2828
run:
29-
shell: "python src/ci/exec-with-shell.py {0}"
29+
shell: bash
3030
jobs:
3131
pr:
3232
name: PR
@@ -54,7 +54,6 @@ jobs:
5454
steps:
5555
- name: disable git crlf conversion
5656
run: git config --global core.autocrlf false
57-
shell: bash
5857
- name: checkout the source code
5958
uses: actions/checkout@v1
6059
with:
@@ -154,7 +153,6 @@ jobs:
154153
steps:
155154
- name: disable git crlf conversion
156155
run: git config --global core.autocrlf false
157-
shell: bash
158156
- name: checkout the source code
159157
uses: actions/checkout@v1
160158
with:
@@ -466,7 +464,6 @@ jobs:
466464
steps:
467465
- name: disable git crlf conversion
468466
run: git config --global core.autocrlf false
469-
shell: bash
470467
- name: checkout the source code
471468
uses: actions/checkout@v1
472469
with:
@@ -592,7 +589,6 @@ jobs:
592589
steps:
593590
- name: disable git crlf conversion
594591
run: git config --global core.autocrlf false
595-
shell: bash
596592
- name: checkout the source code
597593
uses: actions/checkout@v1
598594
with:
@@ -688,6 +684,7 @@ jobs:
688684
fetch-depth: 2
689685
- name: publish toolstate
690686
run: src/ci/publish_toolstate.sh
687+
shell: bash
691688
env:
692689
TOOLSTATE_REPO_ACCESS_TOKEN: "${{ secrets.TOOLSTATE_REPO_ACCESS_TOKEN }}"
693690
if: success() && !env.SKIP_JOB

src/ci/exec-with-shell.py

-16
This file was deleted.

src/ci/github-actions/ci.yml

+5-13
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ x--expand-yaml-anchors--remove:
7979
steps:
8080
- name: disable git crlf conversion
8181
run: git config --global core.autocrlf false
82-
shell: bash
8382

8483
- name: checkout the source code
8584
uses: actions/checkout@v1
@@ -231,18 +230,10 @@ on:
231230

232231
defaults:
233232
run:
234-
# While on Linux and macOS builders it just forwards the arguments to the
235-
# system bash, this wrapper allows switching from the host's bash.exe to
236-
# the one we install along with MSYS2 mid-build on Windows.
237-
#
238-
# Once the step to install MSYS2 is executed, the CI_OVERRIDE_SHELL
239-
# environment variable is set pointing to our MSYS2's bash.exe. From that
240-
# moment the host's bash.exe will not be called anymore.
241-
#
242-
# This is needed because we can't launch our own bash.exe from the host
243-
# bash.exe, as that would load two different cygwin1.dll in memory, causing
244-
# "cygwin heap mismatch" errors.
245-
shell: python src/ci/exec-with-shell.py {0}
233+
# On Linux, macOS, and Windows, use the system-provided bash as the default
234+
# shell. (This should only make a difference on Windows, where the default
235+
# shell is PowerShell.)
236+
shell: bash
246237

247238
jobs:
248239
pr:
@@ -614,6 +605,7 @@ jobs:
614605

615606
- name: publish toolstate
616607
run: src/ci/publish_toolstate.sh
608+
shell: bash
617609
env:
618610
TOOLSTATE_REPO_ACCESS_TOKEN: ${{ secrets.TOOLSTATE_REPO_ACCESS_TOKEN }}
619611
<<: *step

src/ci/scripts/install-msys2.sh

-3
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,6 @@ if isWindows; then
1212
mkdir -p "${msys2Path}/home/${USERNAME}"
1313
ciCommandAddPath "${msys2Path}/usr/bin"
1414

15-
echo "switching shell to use our own bash"
16-
ciCommandSetEnv CI_OVERRIDE_SHELL "${msys2Path}/usr/bin/bash.exe"
17-
1815
# Detect the native Python version installed on the agent. On GitHub
1916
# Actions, the C:\hostedtoolcache\windows\Python directory contains a
2017
# subdirectory for each installed Python version.

0 commit comments

Comments
 (0)