Rollup merge of #117401 - chenyukang:yukang-cleanup-hir-typeck-suggestions, r=compiler-errors

Refactor: move suggestion functions from demand to suggestions

follow-up from
#116841 (comment)

Author: matthiaskrgr