Skip to content

Commit 635817b

Browse files
committed
Auto merge of #57878 - pietroalbini:beta-backports, r=pietroalbini
[beta] Rollup backports * #57857: Fix Android CI failing to download SDKs * #57840: Fix issue 57762 * #57698: Fix typo bug in DepGraph::try_mark_green(). r? @ghost
2 parents 4df66ba + 1652c7d commit 635817b

File tree

4 files changed

+23
-3
lines changed

4 files changed

+23
-3
lines changed

src/ci/docker/scripts/android-sdk.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ download_sysimage() {
2020
# The output from sdkmanager is so noisy that it will occupy all of the 4 MB
2121
# log extremely quickly. Thus we must silence all output.
2222
yes | sdkmanager --licenses > /dev/null
23-
sdkmanager platform-tools emulator \
23+
yes | sdkmanager platform-tools emulator \
2424
"platforms;android-$api" \
2525
"system-images;android-$api;default;$abi" > /dev/null
2626
}

src/librustc/dep_graph/graph.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -600,7 +600,7 @@ impl DepGraph {
600600
DepKind::Hir |
601601
DepKind::HirBody |
602602
DepKind::CrateMetadata => {
603-
if dep_node.extract_def_id(tcx).is_none() {
603+
if dep_dep_node.extract_def_id(tcx).is_none() {
604604
// If the node does not exist anymore, we
605605
// just fail to mark green.
606606
return None

src/librustc_codegen_llvm/debuginfo/metadata.rs

+4-1
Original file line numberDiff line numberDiff line change
@@ -1164,7 +1164,10 @@ fn use_enum_fallback(cx: &CodegenCx) -> bool {
11641164
// On MSVC we have to use the fallback mode, because LLVM doesn't
11651165
// lower variant parts to PDB.
11661166
return cx.sess().target.target.options.is_like_msvc
1167-
|| llvm_util::get_major_version() < 7;
1167+
// LLVM version 7 did not release with an important bug fix;
1168+
// but the required patch is in the LLVM 8. Rust LLVM reports
1169+
// 8 as well.
1170+
|| llvm_util::get_major_version() < 8;
11681171
}
11691172

11701173
// Describes the members of an enum value: An enum is described as a union of
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
2+
// revisions:rpass1 rpass2 rpass3
3+
4+
// See issue #57692.
5+
6+
#![allow(warnings)]
7+
8+
fn main() {
9+
#[cfg(rpass1)]
10+
{
11+
static map: u64 = 0;
12+
}
13+
#[cfg(not(rpass1))]
14+
{
15+
static MAP: u64 = 0;
16+
}
17+
}

0 commit comments

Comments
 (0)