Skip to content

Commit 1f70776

Browse files
authored
Rollup merge of #75587 - RalfJung:mir-comment-fixes, r=ecstatic-morse
mir building: fix some comments r? @oli-obk At least I hope these fixes are right, please double-check.^^
2 parents 672d009 + 75d1373 commit 1f70776

6 files changed

+7
-6
lines changed

src/librustc_mir/transform/mod.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -321,6 +321,7 @@ fn mir_validated(
321321

322322
// Ensure that we compute the `mir_const_qualif` for constants at
323323
// this point, before we steal the mir-const result.
324+
// Also this means promotion can rely on all const checks having been done.
324325
let _ = tcx.mir_const_qualif_opt_const_arg(def);
325326

326327
let mut body = tcx.mir_const(def).steal();
@@ -336,7 +337,7 @@ fn mir_validated(
336337
let promote: &[&dyn MirPass<'tcx>] = &[
337338
// What we need to run borrowck etc.
338339
&promote_pass,
339-
&simplify::SimplifyCfg::new("qualify-consts"),
340+
&simplify::SimplifyCfg::new("promote-consts"),
340341
];
341342

342343
let opt_coverage: &[&dyn MirPass<'tcx>] = if tcx.sess.opts.debugging_opts.instrument_coverage {

src/test/mir-opt/issue-41697.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ trait Foo {
1414
}
1515

1616
// EMIT_MIR_FOR_EACH_BIT_WIDTH
17-
// EMIT_MIR issue_41697.{{impl}}-{{constant}}.SimplifyCfg-qualify-consts.after.mir
17+
// EMIT_MIR issue_41697.{{impl}}-{{constant}}.SimplifyCfg-promote-consts.after.mir
1818
impl Foo for [u8; 1+1] {
1919
fn get(&self) -> [u8; 2] {
2020
*self

src/test/mir-opt/issue_41697.{{impl}}-{{constant}}.SimplifyCfg-qualify-consts.after.mir.32bit renamed to src/test/mir-opt/issue_41697.{{impl}}-{{constant}}.SimplifyCfg-promote-consts.after.mir.32bit

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// MIR for `<impl at $DIR/issue-41697.rs:18:1: 22:2>::{{constant}}#0` after SimplifyCfg-qualify-consts
1+
// MIR for `<impl at $DIR/issue-41697.rs:18:1: 22:2>::{{constant}}#0` after SimplifyCfg-promote-consts
22

33
<impl at $DIR/issue-41697.rs:18:1: 22:2>::{{constant}}#0: usize = {
44
let mut _0: usize; // return place in scope 0 at $DIR/issue-41697.rs:18:19: 18:22

src/test/mir-opt/issue_41697.{{impl}}-{{constant}}.SimplifyCfg-qualify-consts.after.mir.64bit renamed to src/test/mir-opt/issue_41697.{{impl}}-{{constant}}.SimplifyCfg-promote-consts.after.mir.64bit

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// MIR for `<impl at $DIR/issue-41697.rs:18:1: 22:2>::{{constant}}#0` after SimplifyCfg-qualify-consts
1+
// MIR for `<impl at $DIR/issue-41697.rs:18:1: 22:2>::{{constant}}#0` after SimplifyCfg-promote-consts
22

33
<impl at $DIR/issue-41697.rs:18:1: 22:2>::{{constant}}#0: usize = {
44
let mut _0: usize; // return place in scope 0 at $DIR/issue-41697.rs:18:19: 18:22

src/test/mir-opt/loop_test.main.SimplifyCfg-qualify-consts.after.mir renamed to src/test/mir-opt/loop_test.main.SimplifyCfg-promote-consts.after.mir

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// MIR for `main` after SimplifyCfg-qualify-consts
1+
// MIR for `main` after SimplifyCfg-promote-consts
22

33
fn main() -> () {
44
let mut _0: (); // return place in scope 0 at $DIR/loop_test.rs:6:11: 6:11

src/test/mir-opt/loop_test.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
// Tests to make sure we correctly generate falseUnwind edges in loops
44

5-
// EMIT_MIR loop_test.main.SimplifyCfg-qualify-consts.after.mir
5+
// EMIT_MIR loop_test.main.SimplifyCfg-promote-consts.after.mir
66
fn main() {
77
// Exit early at runtime. Since only care about the generated MIR
88
// and not the runtime behavior (which is exercised by other tests)

0 commit comments

Comments
 (0)