Skip to content

Commit 1958e03

Browse files
committed
Add FIXME for auditing optional parameters passed to DIBuilder
1 parent 606fd1f commit 1958e03

File tree

1 file changed

+3
-0
lines changed
  • compiler/rustc_codegen_llvm/src/llvm

1 file changed

+3
-0
lines changed

compiler/rustc_codegen_llvm/src/llvm/ffi.rs

+3
Original file line numberDiff line numberDiff line change
@@ -1624,6 +1624,9 @@ unsafe extern "C" {
16241624
) -> &'a Value;
16251625
}
16261626

1627+
// FIXME(Zalathar): Audit all `Option` parameters, especially in lists, to
1628+
// check that they really are nullable on the C/C++ side. LLVM doesn't appear
1629+
// to actually document which ones are nullable.
16271630
unsafe extern "C" {
16281631
pub(crate) fn LLVMCreateDIBuilder<'ll>(M: &'ll Module) -> *mut DIBuilder<'ll>;
16291632
pub(crate) fn LLVMDisposeDIBuilder<'ll>(Builder: ptr::NonNull<DIBuilder<'ll>>);

0 commit comments

Comments
 (0)