dont disable lint on i128

Author: Jacherr

clippy_lints/src/casts/cast_lossless.rs

@@ -6,7 +6,7 @@ use clippy_utils::ty::is_isize_or_usize;
 use rustc_errors::Applicability;
 use rustc_hir::{Expr, ExprKind, QPath, TyKind};
 use rustc_lint::LateContext;
-use rustc_middle::ty::{self, FloatTy, IntTy, Ty, UintTy};
+use rustc_middle::ty::{self, FloatTy, Ty, UintTy};
 
 use super::{utils, CAST_LOSSLESS};
 
@@ -78,12 +78,9 @@ pub(super) fn check(
 fn should_lint(cx: &LateContext<'_>, expr: &Expr<'_>, cast_from: Ty<'_>, cast_to: Ty<'_>, msrv: &Msrv) -> bool {
     // Do not suggest using From in consts/statics until it is valid to do so (see #2267).
     //
-    // If destination is (U)int128, do not lint because source type cannot be larger
+    // If destination is u128, do not lint because source type cannot be larger
     // If source is bool, still lint due to the lint message differing (refers to style)
-    if in_constant(cx, expr.hir_id)
-        || (!cast_from.is_bool()
-            && (matches!(cast_to.kind(), ty::Int(IntTy::I128)) || matches!(cast_to.kind(), ty::Uint(UintTy::U128))))
-    {
+    if in_constant(cx, expr.hir_id) || (!cast_from.is_bool() && matches!(cast_to.kind(), ty::Uint(UintTy::U128))) {
         return false;
     }
 

tests/ui/cast_lossless_integer.fixed

@@ -30,9 +30,8 @@ fn main() {
 
     let _ = I64::from(1i8);
 
-    // Do not lint if destination type is (U)128
+    // Do not lint if destination type is u128
     // see https://github.com/rust-lang/rust-clippy/issues/12492
-    let _ = 1i8 as i128;
     let _ = 1u8 as u128;
     let _ = 1u8 as U128;
 }

tests/ui/cast_lossless_integer.rs

@@ -30,9 +30,8 @@ fn main() {
 
     let _ = 1i8 as I64;
 
-    // Do not lint if destination type is (U)128
+    // Do not lint if destination type is u128
     // see https://github.com/rust-lang/rust-clippy/issues/12492
-    let _ = 1i8 as i128;
     let _ = 1u8 as u128;
     let _ = 1u8 as U128;
 }

tests/ui/cast_lossless_integer.stderr

@@ -122,13 +122,13 @@ LL |     let _ = 1i8 as I64;
    |             ^^^^^^^^^^ help: try: `I64::from(1i8)`
 
 error: casting `i8` to `i32` may become silently lossy if you later change the type
-  --> tests/ui/cast_lossless_integer.rs:71:13
+  --> tests/ui/cast_lossless_integer.rs:70:13
    |
 LL |     let _ = sign_cast!(x, u8, i8) as i32;
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(sign_cast!(x, u8, i8))`
 
 error: casting `i8` to `i32` may become silently lossy if you later change the type
-  --> tests/ui/cast_lossless_integer.rs:72:13
+  --> tests/ui/cast_lossless_integer.rs:71:13
    |
 LL |     let _ = (sign_cast!(x, u8, i8) + 1) as i32;
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(sign_cast!(x, u8, i8) + 1)`