Includes TODO for constants equivalent to π/180

thiagoarrais · thiagoarrais · commit 10a43d3dbf03 · 2020-07-06T13:36:27.000-03:00
diff --git a/clippy_lints/src/floating_point_arithmetic.rs b/clippy_lints/src/floating_point_arithmetic.rs
@@ -655,6 +655,7 @@ fn check_radians(cx: &LateContext<'_>, expr: &Expr<'_>) {
         if let Some((rvalue, _)) = constant(cx, cx.tables(), div_rhs);
         if let Some((lvalue, _)) = constant(cx, cx.tables(), mul_rhs);
         then {
+            // TODO: also check for constant values near PI/180 or 180/PI
             if (F32(f32_consts::PI) == rvalue || F64(f64_consts::PI) == rvalue) &&
                (F32(180_f32) == lvalue || F64(180_f64) == lvalue)
             {

Original file line number	Diff line number	Diff line change
`@@ -655,6 +655,7 @@ fn check_radians(cx: &LateContext<'_>, expr: &Expr<'_>) {`
`655`	`655`	`if let Some((rvalue, _)) = constant(cx, cx.tables(), div_rhs);`
`656`	`656`	`if let Some((lvalue, _)) = constant(cx, cx.tables(), mul_rhs);`
`657`	`657`	`then {`
	`658`	`+ // TODO: also check for constant values near PI/180 or 180/PI`
`658`	`659`	`if (F32(f32_consts::PI) == rvalue \|\| F64(f64_consts::PI) == rvalue) &&`
`659`	`660`	`(F32(180_f32) == lvalue \|\| F64(180_f64) == lvalue)`
`660`	`661`	`{`