Skip to content

Completions on single colons #13597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Veykril opened this issue Nov 10, 2022 · 2 comments · Fixed by #13611
Closed

Completions on single colons #13597

Veykril opened this issue Nov 10, 2022 · 2 comments · Fixed by #13611
Labels
A-completion autocompletion C-bug Category: bug S-actionable Someone could pick this issue up and work on it right now

Comments

@Veykril
Copy link
Member

Veykril commented Nov 10, 2022

We seem to calculate completions for single colons of paths, we clearly shouldn't do that.

:$0 // shows completions
ResolvedThing:$0 // shows completions
UnresolvedThing:$0 // shows completions
@Veykril Veykril added A-completion autocompletion S-actionable Someone could pick this issue up and work on it right now C-bug Category: bug labels Nov 10, 2022
@yue4u
Copy link
Contributor

yue4u commented Nov 11, 2022

Not sure if I understand the issue correctly but trigger_character is None when the completion is triggered manually therefore following calculations happened. Related code: https://github.com/rust-lang/rust-analyzer/blob/master/crates/rust-analyzer/src/handlers.rs#L815-L825

@Veykril
Copy link
Member Author

Veykril commented Nov 11, 2022

Ye looks like we just need to handle the None case there as well (and ideally add a test case for this, not sure if we have infra for testing trigger characters)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-completion autocompletion C-bug Category: bug S-actionable Someone could pick this issue up and work on it right now
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants