diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 219695210..227aeba5e 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -3,12 +3,25 @@ on: pull_request: merge_group: +env: + MDBOOK_VERSION: 0.4.40 + # When updating, be sure to also update rust-lang/rust. + MDBOOK_SPEC_VERSION: 0.1.0 + jobs: test: name: Test runs-on: ubuntu-latest steps: - uses: actions/checkout@master + - name: Cache + uses: actions/cache@v4 + with: + path: | + ~/.cargo/bin/ + ~/.cargo/.crates.toml + ~/.cargo/.crates2.json + key: ms-${MDBOOK_SPEC_VERSION} - name: Update rustup run: rustup self update - name: Install Rust @@ -19,13 +32,15 @@ jobs: - name: Install mdbook run: | mkdir bin - curl -sSL https://github.com/rust-lang/mdBook/releases/download/v0.4.40/mdbook-v0.4.40-x86_64-unknown-linux-gnu.tar.gz | tar -xz --directory=bin + curl -sSL https://github.com/rust-lang/mdBook/releases/download/v${MDBOOK_VERSION}/mdbook-v${MDBOOK_VERSION}-x86_64-unknown-linux-gnu.tar.gz | tar -xz --directory=bin echo "$(pwd)/bin" >> $GITHUB_PATH - name: Report versions run: | rustup --version rustc -Vv mdbook --version + - name: Install mdbook-spec + run: cargo install --locked mdbook-spec@${MDBOOK_SPEC_VERSION} - name: Run tests run: mdbook test - name: Style checks diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 8cf73c1fd..4877903d2 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -14,10 +14,10 @@ for the Reference. As such, we have the warning saying there's work that needs to be done. Eventually, we plan to make sure everything is well documented enough that we can remove the warning. -It is encouraged for you to read the [introduction] to familiarize yourself -with the kind of content the reference is expected to contain and the -conventions it uses. Also, the [style guide] provides more detailed guidelines -for formatting and content. +It is encouraged for you to read the [introduction] to familiarize yourself with +the kind of content the reference is expected to contain and the conventions it +uses. Also, the [Authoring Guide] provides more detailed guidelines for +formatting and content. ## Critiquing the Reference @@ -68,9 +68,9 @@ This should include links to any relevant information, such as the stabilization PR, the RFC, the tracking issue, and anything else that would be helpful for writing the documentation. +[Authoring Guide]: docs/authoring.md [introduction]: src/introduction.md [issue tracker]: https://github.com/rust-lang/reference/issues [playpen]: https://play.rust-lang.org/ [rust-lang/rust]: https://github.com/rust-lang/rust/ -[style guide]: STYLE.md [unstable]: https://doc.rust-lang.org/nightly/unstable-book/ diff --git a/README.md b/README.md index c52561736..ff75557c6 100644 --- a/README.md +++ b/README.md @@ -12,6 +12,7 @@ what we have for now. - Nightly Rust - [mdbook](https://rust-lang.github.io/mdBook/) +- [`mdbook-spec`](https://github.com/rust-lang/spec/tree/main/mdbook-spec) ## Installing dependencies @@ -29,6 +30,12 @@ build the Reference: cargo install --locked mdbook ``` +Also install `mdbook-spec` which is a preprocessor which adds some Markdown extensions: + +```sh +cargo install --locked mdbook-spec +``` + ## Building To build the Reference, first clone the project: diff --git a/STYLE.md b/STYLE.md index 977637b08..5a6488461 100644 --- a/STYLE.md +++ b/STYLE.md @@ -1,71 +1,5 @@ # Rust reference style guide -Some conventions and content guidelines are specified in the [introduction]. -This document serves as a guide for editors and reviewers. +See the [Authoring Guide] for details on the style used in the reference. -There is a [`style-check`](style-check/) tool which is run in CI to check some of these. To use it locally, run `cargo run --manifest-path=style-check/Cargo.toml src`. - -## Markdown formatting - -* Use ATX-style heading with sentence case. -* Use one line per sentence to make diffs nicer. - Do not wrap long lines. -* Use reference links, with shortcuts if appropriate. - Place the sorted link reference definitions at the bottom of the file, or at the bottom of a section if there is an unusually large number of links that are specific to the section. - - ``` - Example of shortcut link: [enumerations] - Example of reference link with label: [block expression][block] - - [block]: expressions/block-expr.md - [enumerations]: types/enum.md - ``` - -* Links should be relative with the `.md` extension. - Links to other rust-lang books that are published with the reference or the standard library API should also be relative so that the linkchecker can validate them. -* See the [Conventions] section for formatting callouts such as notes, edition differences, and warnings. -* Formatting to avoid: - * Avoid trailing spaces. - * Avoid double blank lines. - -### Code examples - -Code examples should use code blocks with triple backticks. -The language should always be specified (such as `rust`). - -```rust -println!("Hello!"); -``` - -See https://highlightjs.org/ for a list of supported languages. - -Rust examples are tested via rustdoc, and should include the appropriate annotations when tests are expected to fail: - -* `edition2015` or `edition2018` --- If it is edition-specific (see `book.toml` for the default). -* `no_run` --- The example should compile successfully, but should not be executed. -* `should_panic` --- The example should compile and run, but produce a panic. -* `compile_fail` --- The example is expected to fail to compile. -* `ignore` --- The example shouldn't be built or tested. - This should be avoided if possible. - Usually this is only necessary when the testing framework does not support it (such as external crates or modules, or a proc-macro), or it contains pseudo-code which is not valid Rust. - An HTML comment such as `` should be placed before the example to explain why it is ignored. - -See the [rustdoc documentation] for more detail. - -## Language and grammar - -* Use American English spelling. -* Use Oxford commas. -* Idioms and styling to avoid: - * Avoid slashes for alternatives ("program/binary"), use conjunctions or rewrite it ("program or binary"). - * Avoid qualifying something as "in Rust", the entire reference is about Rust. - -## Content - -* Whenever there is a difference between editions, the differences should be called out with an "Edition Differences" block. - The main text should stick to what is common between the editions. - However, for large differences (such as "async"), the main text may contain edition-specific content as long as it is made clear which editions it applies to. - -[conventions]: src/introduction.md#conventions -[introduction]: src/introduction.md -[rustdoc documentation]: https://doc.rust-lang.org/rustdoc/documentation-tests.html +[Authoring Guide]: docs/authoring.md diff --git a/book.toml b/book.toml index 505e0816d..3bafa2492 100644 --- a/book.toml +++ b/book.toml @@ -16,3 +16,5 @@ smart-punctuation = true [rust] edition = "2021" + +[preprocessor.spec] diff --git a/docs/authoring.md b/docs/authoring.md new file mode 100644 index 000000000..256cb3082 --- /dev/null +++ b/docs/authoring.md @@ -0,0 +1,148 @@ +# Authoring Guide + +This document serves as a guide for editors and reviewers. Some conventions and content guidelines are specified in the [introduction]. + +[introduction]: ../src/introduction.md + +## Markdown formatting + +* Use [ATX-style headings][atx] (not Setext) with [sentence case]. +* Do not use tabs, only spaces. +* Files must end with a newline. +* Lines must not end with spaces. Double spaces have semantic meaning, but can be invisible. Use a trailing backslash if you need a hard line break. +* If possible, avoid double blank lines. +* Do not use indented code blocks; use 3+ backticks code blocks instead. +* Code blocks should have an explicit language tag. +* Do not wrap long lines. This helps with reviewing diffs of the source. +* Use [smart punctuation] instead of Unicode characters. For example, use `---` for em-dash instead of the Unicode character. Characters like em-dash can be difficult to see in a fixed-width editor, and some editors may not have easy methods to enter such characters. +* Links should be relative with the `.md` extension. Links to other rust-lang books that are published with the reference or the standard library API should also be relative so that the linkchecker can validate them. +* The use of reference links is preferred, with shortcuts if appropriate. Place the sorted link reference definitions at the bottom of the file, or at the bottom of a section if there are an unusually large number of links that are specific to the section. + + ```markdown + Example of shortcut link: [enumerations] + Example of reference link with label: [block expression][block] + + [block]: expressions/block-expr.md + [enumerations]: types/enum.md + ``` +* See the [Conventions] section for formatting callouts such as notes, edition differences, and warnings. + +There are automated checks for some of these rules. Run `cargo run --manifest-path style-check/Cargo.toml -- src` to run them locally. + +[atx]: https://spec.commonmark.org/0.31.2/#atx-headings +[conventions]: ../src/introduction.md#conventions +[sentence case]: https://apastyle.apa.org/style-grammar-guidelines/capitalization/sentence-case +[smart punctuation]: https://rust-lang.github.io/mdBook/format/markdown.html#smart-punctuation + +### Code examples + +Code examples should use code blocks with triple backticks. The language should always be specified (such as `rust`). + +```rust +println!("Hello!"); +``` + +See for a list of supported languages. + +Rust examples are tested via rustdoc, and should include the appropriate annotations: + +* `edition2015` or `edition2018` --- If it is edition-specific (see `book.toml` for the default). +* `no_run` --- The example should compile successfully, but should not be executed. +* `should_panic` --- The example should compile and run, but produce a panic. +* `compile_fail` --- The example is expected to fail to compile. +* `ignore` --- The example shouldn't be built or tested. This should be avoided if possible. Usually this is only necessary when the testing framework does not support it (such as external crates or modules, or a proc-macro), or it contains pseudo-code which is not valid Rust. An HTML comment such as `` should be placed before the example to explain why it is ignored. +* `Exxxx` --- If the example is expected to fail to compile with a specific error code, include that code so that rustdoc will check that the expected code is used. + +See the [rustdoc documentation] for more detail. + +[rustdoc documentation]: https://doc.rust-lang.org/rustdoc/documentation-tests.html + +## Special markdown constructs + +The following are extensions provided by [`mdbook-spec`](https://github.com/rust-lang/spec/tree/main/mdbook-spec). + +### Rules + +Most clauses should be preceded with a rule. Rules can be specified in the markdown source with the following on a line by itself: + +```markdown +r[foo.bar] +``` + +The rule name should be lowercase, with periods separating from most general to most specific (like `r[array.repeat.zero]`). + +Rules can be linked to by their ID using markdown such as `[foo.bar]`. There are automatic link references so that any rule can be referred to from any page in the book. + +In the HTML, the rules are clickable just like headers. + +### Standard library links + +You should link to the standard library without specifying a URL in a fashion similar to [rustdoc intra-doc links][intra]. Some examples: + +We can link to the page on `Option`: + +```markdown +[`std::option::Option`] +``` + +In these links, generics are ignored and can be included: + +```markdown +[`std::option::Option`] +``` + +If we don't want the full path in the text, we can write: + +```markdown +[`Option`](std::option::Option) +``` + +Macros can end in `!`. This can be helpful for disambiguation. For example, this refers to the macro rather than the module: + +```markdown +[`alloc::vec!`] +``` + +Explicit namespace disambiguation is also supported: + +```markdown +[`std::vec`](mod@std::vec) +``` + +[intra]: https://doc.rust-lang.org/rustdoc/write-documentation/linking-to-items-by-name.html + +### Admonitions + +Admonitions use a style similar to GitHub-flavored markdown, where the style name is placed at the beginning of a blockquote, such as: + +```markdown +> [!WARNING] +> This is a warning. +``` + +All this does is apply a CSS class to the blockquote. You should define the color or style of the rule in the `css/custom.css` file if it isn't already defined. + +## Style + +Idioms and styling to avoid: + +* Use American English spelling. +* Use Oxford commas. +* Avoid slashes for alternatives ("program/binary"); use conjunctions or rewrite it ("program or binary"). +* Avoid qualifying something as "in Rust"; the entire reference is about Rust. + +## Content guidelines + +The following are guidelines for the content of the reference. + +### Targets + +The reference does not document which targets exist, or the properties of specific targets. The reference may refer to *platforms* or *target properties* where required by the language. Some examples: + +* Conditional-compilation keys like `target_os` are specified to exist, but not what their values must be. +* The `windows_subsystem` attribute specifies that it only works on Windows platforms. +* Inline assembly and the `target_feature` attribute specify the architectures that are supported. + +### Editions + +The main text and flow should document only the current edition. Whenever there is a difference between editions, the differences should be called out with an "Edition Differences" block. diff --git a/theme/reference.css b/theme/reference.css index 02e5f63df..8d000fbf0 100644 --- a/theme/reference.css +++ b/theme/reference.css @@ -1,3 +1,5 @@ +/* Custom CSS for the Rust Specification. */ + /* .parenthetical class used to keep e.g. "less-than symbol (<)" from wrapping the end parenthesis onto its own line. Use in a span between the last word and @@ -51,3 +53,167 @@ main .warning p::before { .ayu main .warning p a { color: #80d0d0; } + +/* tags can be used to highlight specific character elements. */ +kbd { + border: 1px solid #999; + display: inline-block; + border-radius: 3px; + padding: 0 0.6ex; + background: #eee; + box-shadow: inset -1px -1px 0 #999; + vertical-align: baseline; + color: #000; + height: 1.55em; + font-style: normal; + font-weight: bold; + font-family: inherit; + font-size: revert; + line-height: revert; +} +kbd.optional { + border-style: dashed; + background: #fff; +} +var.optional { + border-style: dashed; +} + +/* tags can be used for non-terminals. */ +var { + border: 1px solid #9c9; + box-shadow: inset -1px -1px 0 #9c9; + font-style: normal; + display: inline-block; + vertical-align: baseline; + border-radius: 7px; + padding: 0 4px; + background: #dfd; + margin: 2px; +} +var.type { + box-shadow: inset -1px -1px 0 #c99; + border-color: #c99; + background: #fdd; +} + +/* can be used for a grammar production that repeats zero or more times. */ +span.repeat { + position: relative; + border: 1px dashed #393; + border-radius: 10px; + display: inline-block; + padding: 6px; + margin-left: 0.5ex; + margin-top: 1em; + margin-bottom: 0.5ex; + min-width: 3.8em; + text-align: center; +} +span.repeat::before { + content: "zero or more"; + white-space: nowrap; + display: block; + text-align: center; + font-size: 0.75em; + position: absolute; + left: 0; + right: 0; + top: -1.4em; + color: #393; +} +var > span { + display: inline-block; + border-right: 1px dotted green; + padding-right: 0.5ex; + margin-right: 0.5ex; + font-style: italic; +} + +/* can be used to highlight a specific version of Rust. */ +span.version { + float: right; + margin-left: 1em; + margin-bottom: 1em; + background: #f7c0eb; + padding: 0.2ex 0.5ex; + border-radius: 5px; + display: block; + box-shadow: inset -1px -1px 0 #a06894; + font-size: 0.9em; +} + +/* tags are used to indicate a specific word or phrase is being defined. */ +dfn { + font-style: italic; + text-decoration: underline; +} + +.content main { + /* Provides space on the left for the rule call-outs. */ + padding-left: 4em; +} + +/* Rules are generated via r[foo.bar] syntax, processed by mdbook-spec. */ +.rule { + /* Allows the rule to be positioned. */ + position: relative; + /* Position slightly to the left. */ + left: -4em; + color: #999; + font-size: 0.8em; +} +/* mdbook will wrap the rule content in a

tag, with a margin. However, we + don't need the extra space +*/ +.rule ~ p { + margin-top: 0px; +} + +/* Change the default styling of blockquotes. */ +blockquote { + padding: 1ex 1em; + margin: 1ex; + margin-left: 2em; + /* vw units allow this to be adaptive to the screen size so it isn't too small on mobile. */ + margin-right: 12vw; +} + +/* mdbook will wrap the blockquote content in a

tag, with a margin. However, + that adds too much space, so remove it. +*/ +blockquote > p { + margin-top: 0px; + margin-bottom: 0px; +} + +/* When the sidebar is visible, reduce the spacing of rules so that the + content doesn't get shifted too far, and make the text too narrow. +*/ +.sidebar-visible .rule { + left: -1em; +} +.sidebar-visible .content main { + padding-left: 1em; +} + +/* Remove the blue coloring of links on rules that mdbook normally sets. */ +.rule-link { + color: #999 !important; +} + +/* When clicking a rule, it is added as a URL fragment and the browser will + navigate to it. This adds an indicator that the linked rule is the one that + is "current", just like normal headers are in mdbook. +*/ +.rule:target::before { + display: inline-block; + content: "ยป"; + margin-inline-start: -20px; + width: 20px; +} + +/* Sets the color for [!HISTORY] blockquote admonitions. */ +.history > blockquote { + background: #f7c0eb; +}