Merge pull request #381 from ehuss/fix-all-pick

Remove implicit "all" group choice.

Author: Mark-Simulacrum

highfive/newpr.py

@@ -252,8 +252,6 @@ def find_reviewer(self, msg, exclude):
             if match:
                 groups = self.get_groups()
                 potential = groups.get(match.group(2)) or groups.get("%s/%s" % (match.group(1), match.group(2))) or []
-                if 'all' in groups:
-                    potential.extend(groups["all"])
                 picked = self.pick_reviewer(groups, potential, exclude)
                 if picked:
                     return picked

highfive/tests/fakes.py

@@ -86,7 +86,7 @@ def get_repo_configs():
             }
         },
         'teams': {
-            "groups": {"all": [], "a": ["@pnkfelix"], "d": ["@e"], "compiler-team": ["@niko"], "b/c": ["@nrc"]}
+            "groups": {"all": ["@ehuss"], "a": ["@pnkfelix"], "d": ["@e"], "compiler-team": ["@niko"], "b/c": ["@nrc"]}
         }
     }