Skip to content

when stable, use core::arch::arm to implement cortex_m::asm #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
japaric opened this issue Aug 2, 2018 · 4 comments
Closed

when stable, use core::arch::arm to implement cortex_m::asm #101

japaric opened this issue Aug 2, 2018 · 4 comments
Labels

Comments

@japaric
Copy link
Member

japaric commented Aug 2, 2018

this will let us provide the cortex_m::asm API on stable without depending on an external assembler.

@japaric
Copy link
Member Author

japaric commented Aug 21, 2018

Triage: blocked on cortex_m::asm being stabilized.

@japaric japaric removed this from the RC1 milestone Aug 27, 2018
@japaric
Copy link
Member Author

japaric commented Aug 27, 2018

Removing from the RC1 (edition) milestone because thanks to PR #108 this crate no longer on GCC so this is just a nice to have.

@japaric japaric removed their assignment Jan 12, 2019
@jonas-schievink
Copy link
Contributor

We now use Rust's new inline assembly (rust-lang/rust#72016) and an FFI shim to implement cortex_m::asm, removing the need for any external tooling. Inline asm has higher chances of being stabilized than core::arch::arm, so maybe we should close this issue? (doesn't seem too important to keep tracking this; we can remove the FFI shim once inline asm is stable)

@adamgreig
Copy link
Member

SGTM. I agree that inline asm getting stabilised looks more likely than all the relevant instructions landing in core::arch::arm, and in any event we need a few assembly routines for some methods anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants