cmds: don't call flag.Parse in init

When flag.Parse is in main, it is _only_ called in the command binary.

When flag.Parse is in init, it is _also_ called in the test binary. The
test binary, however, likes to register its own flags, which due to init
ordering usually happens after the command's inits.

In Go 1.13, flag registration was delayed to be later in the init
process, which is how this issue came up.

See also golang/go#31859

Signed-off-by: Chris Koch <chrisko@google.com>

Author: hugelgupf

cmds/core/date/date.go

@@ -59,7 +59,6 @@ func init() {
 	}
 	flag.BoolVar(&flags.universal, "u", false, "Coordinated Universal Time (UTC)")
 	flag.StringVar(&flags.reference, "r", "", "Display the last midification time of FILE")
-	flag.Parse()
 }
 
 // regex search for +format POSIX patterns
@@ -212,6 +211,8 @@ func date(t time.Time, z *time.Location) string {
 }
 
 func main() {
+	flag.Parse()
+
 	t := time.Now()
 	z := time.Local
 	if flags.universal {

cmds/core/mkfifo/mkfifo.go

@@ -33,7 +33,6 @@ func init() {
 		os.Args[0] = cmd
 		defUsage()
 	}
-	flag.Parse()
 }
 
 func main() {

cmds/core/readlink/readlink.go

@@ -35,7 +35,6 @@ func init() {
 		os.Args[0] = cmd
 		defUsage()
 	}
-	flag.Parse()
 }
 
 func readLink(file string) error {
@@ -57,6 +56,8 @@ func readLink(file string) error {
 }
 
 func main() {
+	flag.Parse()
+
 	var exitStatus int
 
 	for _, file := range flag.Args() {