fix relative paths for custom graph report directory

fixes #575

Author: RBusarow

build.gradle.kts

@@ -49,6 +49,12 @@ moduleCheck {
   checks {
     sortDependencies = true
   }
+  reports {
+    graphs {
+      enabled = true
+      outputDir = File(buildDir, "depths").path
+    }
+  }
 }
 
 tasks.named("ktlintFormat") {

modulecheck-core/build.gradle.kts

@@ -57,7 +57,6 @@ dependencies {
   testImplementation(project(path = ":modulecheck-config:fake"))
   testImplementation(project(path = ":modulecheck-internal-testing"))
   testImplementation(project(path = ":modulecheck-parsing:source:api"))
-  testImplementation(project(path = ":modulecheck-project:api"))
   testImplementation(project(path = ":modulecheck-project:testing"))
   testImplementation(project(path = ":modulecheck-runtime:testing"))
   testImplementation(project(path = ":modulecheck-utils"))

modulecheck-gradle/plugin/src/test/kotlin/modulecheck/gradle/GraphReportTaskTest.kt

@@ -109,8 +109,11 @@ internal class GraphReportTaskTest : BasePluginTest() {
       "app", "build", "reports", "modulecheck", "graphs", "main.dot"
     ) shouldHaveText """
       strict digraph DependencyGraph {
-        ratio=0.5;
-        node [style="rounded,filled" shape=box];
+        ratio = 0.5625;
+        node [style = "rounded,filled" shape = box];
+
+        labelloc = "t"
+        label = ":app -- main";
 
         ":app" [fillcolor = "#F89820"];
         ":lib1" [fillcolor = "#F89820"];
@@ -121,9 +124,9 @@ internal class GraphReportTaskTest : BasePluginTest() {
 
         ":lib2" -> ":lib1" [style = bold; color = "#007744"];
 
-        {rank = same; ":lib1";}
-        {rank = same; ":lib2";}
-        {rank = same; ":app";}
+        { rank = same; ":lib1"; }
+        { rank = same; ":lib2"; }
+        { rank = same; ":app"; }
       }
     """
   }

modulecheck-reporting/graphviz/build.gradle.kts

@@ -34,4 +34,11 @@ dependencies {
   testImplementation(libs.bundles.hermit)
   testImplementation(libs.bundles.jUnit)
   testImplementation(libs.bundles.kotest)
+  testImplementation(libs.kotlin.reflect)
+  testImplementation(libs.rickBusarow.dispatch.test.core)
+
+  testImplementation(project(path = ":modulecheck-core"))
+  testImplementation(project(path = ":modulecheck-project:api"))
+  testImplementation(project(path = ":modulecheck-project:testing"))
+  testImplementation(project(path = ":modulecheck-runtime:testing"))
 }

modulecheck-reporting/graphviz/src/main/kotlin/modulecheck/reporting/graphviz/GraphvizFactory.kt

@@ -49,8 +49,11 @@ class GraphvizFactory @Inject constructor(
 
       appendLine(
         """
-        |ratio=0.5;
-        |node [style="rounded,filled" shape=box];
+        |ratio = 0.5625;
+        |node [style = "rounded,filled" shape = box];
+        |
+        |labelloc = "t"
+        |label = "${root.dependentPath.value} -- ${root.sourceSetName.value}";
         |
         """.trimMargin()
       )
@@ -139,7 +142,7 @@ class GraphvizFactory @Inject constructor(
           .sortedBy { it.dependentPath }
           .joinToString("; ", postfix = ";") { it.dependentProject.pathString() }
 
-        appendLine("{rank = same; $paths}")
+        appendLine("{ rank = same; $paths }")
       }
   }
 

modulecheck-reporting/graphviz/src/main/kotlin/modulecheck/reporting/graphviz/GraphvizFileWriter.kt

@@ -34,30 +34,24 @@ class GraphvizFileWriter @Inject constructor(
       val rootOrNull = settings.reports.graphs.outputDir?.let { File(it) }
 
       depths
-        .filter {
-          // Don't generate a graph if the SourceSet doesn't exist at all.
-          // For example, if it's an Android project there will be an `androidTest` SourceSet,
-          // but if there are no `androidTestImplementation` dependencies and no files, then skip it.
-          it.depth != 0 || it.dependentProject
-            .sourceSets[it.sourceSetName]
-            ?.hasExistingSourceFiles == true
-        }
         // Generate the low-depth graphs first, because their data is memoized and used to create the
         // graphs for high-depth projects.
         .sorted()
         .forEach { depth ->
 
           launchIO {
 
-            val root = rootOrNull ?: depth.dependentProject.projectDir
-
-            val graphFile = root.child(
-              "build",
-              "reports",
-              "modulecheck",
-              "graphs",
+            val graphFile = rootOrNull?.child(
+              depth.dependentPath.value.replace(":", File.separator),
               "${depth.sourceSetName.value}.dot"
             )
+              ?: depth.dependentProject.projectDir.child(
+                "build",
+                "reports",
+                "modulecheck",
+                "graphs",
+                "${depth.sourceSetName.value}.dot"
+              )
 
             val depthReport = graphvizFactory.create(depth)