diff --git a/CHANGELOG.md b/CHANGELOG.md index 6d29a73e..8b5bf9d9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ ## Next version - BREAKING: Fixes the type of `RegExp.Result.t` to be `array>` instead of `array`. https://github.com/rescript-association/rescript-core/pull/234. +- Fix type of `Nullable.t` which was not untagged in the implementation. https://github.com/rescript-association/rescript-core/pull/235 ## 1.4.0 diff --git a/src/Core__Nullable.res b/src/Core__Nullable.res index 6a918473..a1d321da 100644 --- a/src/Core__Nullable.res +++ b/src/Core__Nullable.res @@ -1,3 +1,4 @@ +@unboxed type t<'a> = Js.Nullable.t<'a> = | Value('a) | @as(null) Null diff --git a/src/intl/Core__Intl__Common.res b/src/intl/Core__Intl__Common.res index e0cea141..6cc3a625 100644 --- a/src/intl/Core__Intl__Common.res +++ b/src/intl/Core__Intl__Common.res @@ -1,4 +1,4 @@ -type localeMatcher = [#lookup | @as("best fit") #bestFit] +type localeMatcher = [#lookup | #"best fit"] type calendar = [ | #buddhist diff --git a/src/intl/Core__Intl__DateTimeFormat.res b/src/intl/Core__Intl__DateTimeFormat.res index 1b9cec98..04e4dac8 100644 --- a/src/intl/Core__Intl__DateTimeFormat.res +++ b/src/intl/Core__Intl__DateTimeFormat.res @@ -26,7 +26,7 @@ type timeZoneName = [ ] type hourCycle = [#h11 | #h12 | #h23 | #h24] -type formatMatcher = [#basic | @as("best fit") #bestFit] +type formatMatcher = [#basic | #"best fit"] type fractionalSecondDigits = [#0 | #1 | #2 | #3] type options = {