Skip to content

Commit 1a4e895

Browse files
authored
Fix type of Nullable.t which was not untagged in the implementation. (#235)
* Fix type of `Nullable.t` which was not untagged in the implementation. * More fixes w.r.t. compiler master. Unused `as` annotations are not picked up. * Use #"best fit"
1 parent 199633b commit 1a4e895

File tree

4 files changed

+4
-2
lines changed

4 files changed

+4
-2
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
## Next version
44

55
- BREAKING: Fixes the type of `RegExp.Result.t` to be `array<option<string>>` instead of `array<string>`. https://github.com/rescript-association/rescript-core/pull/234.
6+
- Fix type of `Nullable.t` which was not untagged in the implementation. https://github.com/rescript-association/rescript-core/pull/235
67

78
## 1.4.0
89

src/Core__Nullable.res

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
@unboxed
12
type t<'a> = Js.Nullable.t<'a> =
23
| Value('a)
34
| @as(null) Null

src/intl/Core__Intl__Common.res

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
type localeMatcher = [#lookup | @as("best fit") #bestFit]
1+
type localeMatcher = [#lookup | #"best fit"]
22

33
type calendar = [
44
| #buddhist

src/intl/Core__Intl__DateTimeFormat.res

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ type timeZoneName = [
2626
]
2727

2828
type hourCycle = [#h11 | #h12 | #h23 | #h24]
29-
type formatMatcher = [#basic | @as("best fit") #bestFit]
29+
type formatMatcher = [#basic | #"best fit"]
3030
type fractionalSecondDigits = [#0 | #1 | #2 | #3]
3131

3232
type options = {

0 commit comments

Comments
 (0)