Skip to content

Commit a10699a

Browse files
Adjust opp-oprt.sh to export large variables at the end of the file. Fix un-exporting mechanism.
Signed-off-by: Marek Szymutko <mszymutk@redhat.com>
1 parent db73987 commit a10699a

File tree

2 files changed

+22
-29
lines changed

2 files changed

+22
-29
lines changed

ci/scripts/opp-env.sh

Lines changed: 5 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -77,28 +77,11 @@ echo "OPP_LABELS=$OPP_LABELS"
7777
# to error "Argument list too long".
7878
# Therefore we have to undo the exporting by
7979
# unsetting them before running any non-builtins
80-
tmp="$OPP_ADDED_MODIFIED_FILES"
81-
unset OPP_ADDED_MODIFIED_FILES
82-
OPP_ADDED_MODIFIED_FILES="$tmp"
83-
84-
tmp="$OPP_MODIFIED_FILES"
85-
unset OPP_MODIFIED_FILES
86-
OPP_MODIFIED_FILES="$tmp"
87-
88-
tmp="$OPP_RENAMED_FILES"
89-
unset OPP_RENAMED_FILES
90-
OPP_RENAMED_FILES="$tmp"
91-
92-
tmp="$OPP_REMOVED_FILES"
93-
unset OPP_REMOVED_FILES
94-
OPP_REMOVED_FILES="$tmp"
95-
96-
tmp="$OPP_LABELS"
97-
unset OPP_LABELS
98-
OPP_LABELS="$tmp"
99-
100-
unset tmp
101-
# Un-exporting done
80+
export -n OPP_ADDED_MODIFIED_FILES
81+
export -n OPP_MODIFIED_FILES
82+
export -n OPP_RENAMED_FILES
83+
export -n OPP_REMOVED_FILES
84+
export -n OPP_LABELS
10285

10386
echo "opp_error_code=$OPP_ERROR_CODE" >> $GITHUB_OUTPUT
10487
echo "opp_recreate=${OPP_RECREATE}" >> $GITHUB_OUTPUT

ci/scripts/opp-oprt.sh

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -64,12 +64,12 @@ echo "Repo rebased over branch OPP_OPRT_SRC_BRANCH - $OPP_OPRT_SRC_BRANCH"
6464
[[ $OPP_MIRROR_INDEX_MULTIARCH_IMAGE != "" ]] && OPP_EXEC_USER="$OPP_EXEC_USER -e mirror_multiarch_image=$OPP_MIRROR_INDEX_MULTIARCH_IMAGE"
6565
[ -n "$IIB_INPUT_REGISTRY_USER" ] && export OPP_EXEC_USER="$OPP_EXEC_USER -e registry_redhat_io_user=$IIB_INPUT_REGISTRY_USER"
6666
[ -n "$IIB_INPUT_REGISTRY_TOKEN" ] && export OPP_EXEC_USER_SECRETS="$OPP_EXEC_USER_SECRETS -e registry_redhat_io_token=$IIB_INPUT_REGISTRY_TOKEN"
67-
export OPP_ADDED_FILES=$(git diff --diff-filter=A upstream/$OPP_OPRT_SRC_BRANCH --name-only | tr '\r\n' ' ')
68-
export OPP_MODIFIED_FILES=$(git diff --diff-filter=M upstream/$OPP_OPRT_SRC_BRANCH --name-only | tr '\r\n' ' ')
69-
export OPP_REMOVED_FILES=$(git diff --diff-filter=D upstream/$OPP_OPRT_SRC_BRANCH --name-only | tr '\r\n' ' ')
70-
export OPP_RENAMED_FILES=$(git diff --diff-filter=R upstream/$OPP_OPRT_SRC_BRANCH --name-only | tr '\r\n' ' ')
71-
export OPP_ADDED_MODIFIED_FILES=$(git diff --diff-filter=AM upstream/$OPP_OPRT_SRC_BRANCH --name-only | tr '\r\n' ' ')
72-
export OPP_ADDED_MODIFIED_RENAMED_FILES=$(git diff --diff-filter=RAM upstream/$OPP_OPRT_SRC_BRANCH --name-only | tr '\r\n' ' ')
67+
OPP_ADDED_FILES=$(git diff --diff-filter=A upstream/$OPP_OPRT_SRC_BRANCH --name-only | tr '\r\n' ' ')
68+
OPP_MODIFIED_FILES=$(git diff --diff-filter=M upstream/$OPP_OPRT_SRC_BRANCH --name-only | tr '\r\n' ' ')
69+
OPP_REMOVED_FILES=$(git diff --diff-filter=D upstream/$OPP_OPRT_SRC_BRANCH --name-only | tr '\r\n' ' ')
70+
OPP_RENAMED_FILES=$(git diff --diff-filter=R upstream/$OPP_OPRT_SRC_BRANCH --name-only | tr '\r\n' ' ')
71+
OPP_ADDED_MODIFIED_FILES=$(git diff --diff-filter=AM upstream/$OPP_OPRT_SRC_BRANCH --name-only | tr '\r\n' ' ')
72+
OPP_ADDED_MODIFIED_RENAMED_FILES=$(git diff --diff-filter=RAM upstream/$OPP_OPRT_SRC_BRANCH --name-only | tr '\r\n' ' ')
7373

7474
export OPP_CURRENT_PROJECT_REPO="$OPP_OPRT_SRC_REPO"
7575
export OPP_CURRENT_PROJECT_BRANCH="$OPP_OPRT_SRC_BRANCH"
@@ -111,4 +111,14 @@ if [ -n "$OPP_THIS_PR" ];then
111111
export OPP_APPROVED_LIST=$(cat /tmp/approved_list.json | jq -r '[.[-1] | {user: .user.login, state: .state}] | map(select(.state == "APPROVED")) | .[].user' | tr '\n' ' ')
112112
fi
113113
echo "OPP_APPROVED_LIST=$OPP_APPROVED_LIST"
114-
bash <(curl -sL $OPP_SCRIPT_ENV_URL)
114+
115+
OPP_SCRIPT_FILE_CONTENTS=$(curl -sL "$OPP_SCRIPT_ENV_URL")
116+
117+
# Variables expected to have many values are exported near the end
118+
export OPP_ADDED_FILES
119+
export OPP_MODIFIED_FILES
120+
export OPP_REMOVED_FILES
121+
export OPP_RENAMED_FILES
122+
export OPP_ADDED_MODIFIED_FILES
123+
export OPP_ADDED_MODIFIED_RENAMED_FILES
124+
bash <(echo "$OPP_SCRIPT_FILE_CONTENTS")

0 commit comments

Comments
 (0)