Merge branch 'master' of github.com:react-native-community/hooks

pvinis · pvinis · commit d9cc84625565 · 2020-04-13T16:53:57.000+02:00
diff --git a/.all-contributorsrc b/.all-contributorsrc
@@ -194,7 +194,9 @@
       "avatar_url": "https://avatars1.githubusercontent.com/u/17288652?v=4",
       "profile": "https://github.com/Gamal-Shaban",
       "contributions": [
-        "code"
+        "code",
+        "doc",
+        "test"
       ]
     }
   ],
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,51 @@
+# v2.4.9 (Mon Apr 13 2020)
+
+:tada: This release contains work from a new contributor! :tada:
+
+Thank you, WhiteSource Renovate ([@renovate-bot](https://github.com/renovate-bot)), for all your work!
+
+#### 🐛 Bug Fix
+
+- Update dependency @auto-it/first-time-contributor to v9.26.4 [#134](https://github.com/react-native-community/hooks/pull/134) ([@renovate-bot](https://github.com/renovate-bot))
+- add value to Coordinates when hide [#120](https://github.com/react-native-community/hooks/pull/120) ([@Gamal-Shaban](https://github.com/Gamal-Shaban) [@pvinis](https://github.com/pvinis))
+- Update dependency @auto-it/all-contributors to v9.26.8 [#114](https://github.com/react-native-community/hooks/pull/114) ([@renovate-bot](https://github.com/renovate-bot) [@renovate[bot]](https://github.com/renovate[bot]))
+- Update dependency ts-jest to v25.3.1 [#119](https://github.com/react-native-community/hooks/pull/119) ([@renovate-bot](https://github.com/renovate-bot) [@renovate[bot]](https://github.com/renovate[bot]))
+- Update dependency @types/react-native to v0.62.2 [#110](https://github.com/react-native-community/hooks/pull/110) ([@renovate-bot](https://github.com/renovate-bot) [@renovate[bot]](https://github.com/renovate[bot]))
+- Update dependency auto to v9.26.8 [#123](https://github.com/react-native-community/hooks/pull/123) ([@renovate-bot](https://github.com/renovate-bot) [@renovate[bot]](https://github.com/renovate[bot]))
+- Update dependency jest to v25.3.0 [#138](https://github.com/react-native-community/hooks/pull/138) ([@renovate-bot](https://github.com/renovate-bot) [@renovate[bot]](https://github.com/renovate[bot]))
+- Update rn orb to v4 [#141](https://github.com/react-native-community/hooks/pull/141) ([@renovate-bot](https://github.com/renovate-bot) [@renovate[bot]](https://github.com/renovate[bot]))
+- Update dependency eslint-plugin-prettier to v3.1.3 [#142](https://github.com/react-native-community/hooks/pull/142) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency @auto-it/first-time-contributor to v9.26.8 [#137](https://github.com/react-native-community/hooks/pull/137) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency react-native to v0.62.2 [#139](https://github.com/react-native-community/hooks/pull/139) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency @auto-it/first-time-contributor to v9.26.6 [#136](https://github.com/react-native-community/hooks/pull/136) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency @auto-it/first-time-contributor to v9.26.5 [#135](https://github.com/react-native-community/hooks/pull/135) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency @types/jest to v25.2.1 [#129](https://github.com/react-native-community/hooks/pull/129) ([@renovate-bot](https://github.com/renovate-bot) [@renovate[bot]](https://github.com/renovate[bot]))
+- Update dependency @auto-it/first-time-contributor to v9.26.3 [#133](https://github.com/react-native-community/hooks/pull/133) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency @auto-it/first-time-contributor to v9.26.2 [#132](https://github.com/react-native-community/hooks/pull/132) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency prettier to v2.0.4 [#131](https://github.com/react-native-community/hooks/pull/131) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency @auto-it/first-time-contributor to v9.26.1 [#115](https://github.com/react-native-community/hooks/pull/115) ([@renovate-bot](https://github.com/renovate-bot) [@renovate[bot]](https://github.com/renovate[bot]))
+- Update dependency prettier to v2.0.3 [#130](https://github.com/react-native-community/hooks/pull/130) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency react-native to v0.62.1 [#128](https://github.com/react-native-community/hooks/pull/128) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency jest to v25.2.7 [#127](https://github.com/react-native-community/hooks/pull/127) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency @types/jest to v25.1.5 [#126](https://github.com/react-native-community/hooks/pull/126) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency all-contributors-cli to v6.14.1 [#125](https://github.com/react-native-community/hooks/pull/125) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency jest to v25.2.6 [#124](https://github.com/react-native-community/hooks/pull/124) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency auto to v9.22.4 [#122](https://github.com/react-native-community/hooks/pull/122) ([@renovate-bot](https://github.com/renovate-bot))
+- Update dependency auto to v9.22.2 [#121](https://github.com/react-native-community/hooks/pull/121) ([@renovate-bot](https://github.com/renovate-bot))
+
+#### ⚠️  Pushed to `master`
+
+- dont worry about canary, since we cant publish from forks ([@pvinis](https://github.com/pvinis))
+
+#### Authors: 4
+
+- [@renovate[bot]](https://github.com/renovate[bot])
+- Gamal Shaban ([@Gamal-Shaban](https://github.com/Gamal-Shaban))
+- Pavlos Vinieratos ([@pvinis](https://github.com/pvinis))
+- WhiteSource Renovate ([@renovate-bot](https://github.com/renovate-bot))
+
+---
+
 # v2.4.8 (Mon Mar 30 2020)
 
 :tada: This release contains work from new contributors! :tada:
diff --git a/README.md b/README.md
@@ -186,7 +186,7 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
     <td align="center"><a href="https://dylanvann.com/"><img src="https://avatars0.githubusercontent.com/u/1537615?v=4" width="100px;" alt=""/><br /><sub><b>Dylan Vann</b></sub></a><br /><a href="https://github.com/react-native-community/hooks/commits?author=DylanVann" title="Code">💻</a></td>
     <td align="center"><a href="https://github.com/thinklinux"><img src="https://avatars1.githubusercontent.com/u/326949?v=4" width="100px;" alt=""/><br /><sub><b>Tihomir Valkanov</b></sub></a><br /><a href="https://github.com/react-native-community/hooks/commits?author=thinklinux" title="Documentation">📖</a></td>
     <td align="center"><a href="http://twitter.com/pistoudev"><img src="https://avatars1.githubusercontent.com/u/6703711?v=4" width="100px;" alt=""/><br /><sub><b>Pierre Skowron</b></sub></a><br /><a href="https://github.com/react-native-community/hooks/commits?author=pistou" title="Code">💻</a></td>
-    <td align="center"><a href="https://github.com/Gamal-Shaban"><img src="https://avatars1.githubusercontent.com/u/17288652?v=4" width="100px;" alt=""/><br /><sub><b>Gamal Shaban</b></sub></a><br /><a href="https://github.com/react-native-community/hooks/commits?author=Gamal-Shaban" title="Code">💻</a></td>
+    <td align="center"><a href="https://github.com/Gamal-Shaban"><img src="https://avatars1.githubusercontent.com/u/17288652?v=4" width="100px;" alt=""/><br /><sub><b>Gamal Shaban</b></sub></a><br /><a href="https://github.com/react-native-community/hooks/commits?author=Gamal-Shaban" title="Code">💻</a> <a href="https://github.com/react-native-community/hooks/commits?author=Gamal-Shaban" title="Documentation">📖</a> <a href="https://github.com/react-native-community/hooks/commits?author=Gamal-Shaban" title="Tests">⚠️</a></td>
   </tr>
 </table>
 
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@react-native-community/hooks",
-  "version": "2.4.8",
+  "version": "2.4.9",
   "description": "",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
diff --git a/src/useKeyboard.ts b/src/useKeyboard.ts
@@ -1,15 +1,23 @@
 import {useEffect, useState} from 'react'
 import {Keyboard, KeyboardEventListener, ScreenRect} from 'react-native'
 
+const emptyCoordinates = Object.freeze({
+  screenX: 0,
+  screenY: 0,
+  width: 0,
+  height: 0,
+})
+const initialValue = {
+  start: emptyCoordinates,
+  end: emptyCoordinates,
+}
+
 export function useKeyboard() {
   const [shown, setShown] = useState(false)
   const [coordinates, setCoordinates] = useState<{
     start: ScreenRect
     end: ScreenRect
-  }>({
-    start: {screenX: 0, screenY: 0, width: 0, height: 0},
-    end: {screenX: 0, screenY: 0, width: 0, height: 0},
-  })
+  }>(initialValue)
   const [keyboardHeight, setKeyboardHeight] = useState<number>(0)
 
   const handleKeyboardWillShow: KeyboardEventListener = (e) => {
@@ -27,8 +35,10 @@ export function useKeyboard() {
     setShown(false)
     if (e) {
       setCoordinates({start: e.startCoordinates, end: e.endCoordinates})
+    } else {
+      setCoordinates(initialValue)
+      setKeyboardHeight(0)
     }
-    setKeyboardHeight(0)
   }
 
   useEffect(() => {

Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,9 @@`
`194`	`194`	`"avatar_url": "https://avatars1.githubusercontent.com/u/17288652?v=4",`
`195`	`195`	`"profile": "https://github.com/Gamal-Shaban",`
`196`	`196`	`"contributions": [`
`197`		`- "code"`
	`197`	`+ "code",`
	`198`	`+ "doc",`
	`199`	`+ "test"`
`198`	`200`	`]`
`199`	`201`	`}`
`200`	`202`	`],`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@react-native-community/hooks",`
`3`		`- "version": "2.4.8",`
	`3`	`+ "version": "2.4.9",`
`4`	`4`	`"description": "",`
`5`	`5`	`"main": "lib/index.js",`
`6`	`6`	`"types": "lib/index.d.ts",`