-
Notifications
You must be signed in to change notification settings - Fork 121
Minimized es-module-shims + @hotwired/stimulus-loading in Safari #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
You don't have a controller called |
I have a similar problem: https://discuss.hotwired.dev/t/importmap-rails-0-9-0-broke-stimulus/3506 After upgrading to <%= javascript_importmap_tags %> To: <%= javascript_importmap_tags shim: false %>
<%= javascript_importmap_shim_tag minimized: false %> It seems to work but then I get console errors that say:
EDIT: For me it is the same in every browser, not just safari. The below image is from Firefox: |
@dhh I do have that controller — switching to non-minified version of the shims makes everything work fine again (however I also see the JS error about missing .map file as @mhenrixon described above). It seems to me the .min and .map versions of the shims packaged with the 0.9.0 release are somehow corrupted. I will try to find time to investigate more tomorrow. |
There was an error with the minified version that was included. Released 0.9.1 with the correction. Should be all good. Thanks for reporting! |
Thank you! |
Upgrading to
importmap-rails v0.9.0
results in issues with eager- or lazyLoad of Stimulus controllers (using@hotwired/stimulus-loading
).= javascript_importmap_tags
JS console:
I was able to find out that switching to non-minified version of es-module-shims resolves the issue
The text was updated successfully, but these errors were encountered: