Skip to content

Consider making ConnectionFactory.HostName a property #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nkumars opened this issue Jul 5, 2016 · 2 comments
Closed

Consider making ConnectionFactory.HostName a property #217

nkumars opened this issue Jul 5, 2016 · 2 comments
Assignees
Milestone

Comments

@nkumars
Copy link

nkumars commented Jul 5, 2016

Hi,

The properties in RabbitMQ.Client.ConnectionFactory such as UserName and Password are actually set as properties (means it has {get;set;}) whereas for HostName does not exist, which actually forces us to use GetField method while the other two can be used with GetProperty.

I dont know the purpose behind this, but I would suggest to have a consistent declaration, i.e., with {get;set;} or without.

Below is the screenshot that describes my explanation.

fieldandpropertyissue

Regards,
Naveen

@michaelklishin michaelklishin changed the title Issue in declaring the variables in Connection Factory Consider making ConnectionFactory.HostName a property Jul 5, 2016
@michaelklishin michaelklishin added this to the 3.6.x milestone Jul 5, 2016
@kjnilsson
Copy link
Contributor

Field -> Property is a breaking change as applications using .e.g HostName would need to be recompiled. I propose moving this to the 3.7 (v4.0.0) milestone and address it there.

@michaelklishin michaelklishin modified the milestones: 3.7.0, 3.6.x Jul 21, 2016
@michaelklishin
Copy link
Contributor

@kjnilsson fair enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants