From 563e87b72346a5026741d091f3e14a51efe973fd Mon Sep 17 00:00:00 2001 From: Michael Chirico Date: Tue, 28 Nov 2023 02:29:35 +0000 Subject: [PATCH 1/2] avoid paste0 overhead --- R/is_lint_level.R | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/R/is_lint_level.R b/R/is_lint_level.R index 351128e7e..1b82af180 100644 --- a/R/is_lint_level.R +++ b/R/is_lint_level.R @@ -19,9 +19,8 @@ #' #' @export is_lint_level <- function(source_expression, level = c("expression", "file")) { - stopifnot(!missing(level)) level <- match.arg(level) - required_key <- paste0(if (level == "file") "full_", "parsed_content") + required_key <- if (level == "file") "full_parsed_content" else "parsed_content" required_key %in% names(source_expression) } From 38453f4906785420a1802472fa16012d9b26730e Mon Sep 17 00:00:00 2001 From: Michael Chirico Date: Tue, 28 Nov 2023 02:38:34 +0000 Subject: [PATCH 2/2] use switch() for further micro-optimization --- R/is_lint_level.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/R/is_lint_level.R b/R/is_lint_level.R index 1b82af180..d850c51cf 100644 --- a/R/is_lint_level.R +++ b/R/is_lint_level.R @@ -20,7 +20,7 @@ #' @export is_lint_level <- function(source_expression, level = c("expression", "file")) { level <- match.arg(level) - required_key <- if (level == "file") "full_parsed_content" else "parsed_content" + required_key <- switch(level, file = "full_parsed_content", expression = "parsed_content") required_key %in% names(source_expression) }