Skip to content

Custom metadata for top-level '(a <- foo(x))' being used to induce printing #2257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MichaelChirico opened this issue Nov 8, 2023 · 1 comment · Fixed by #2414
Closed
Milestone

Comments

@MichaelChirico
Copy link
Collaborator

Have seen a few hits on implicit_assignment_linter() like:

(a <- foo(x))

Here, the lint message can mention explicitly using print() for readability rather than this shorthand.

We should of course be careful not to mix this case which is similar on the parse tree:

AA && (BB <- foo(x))
@AshesITR
Copy link
Collaborator

AshesITR commented Nov 8, 2023

Agreed. Linting only a top-level parenthesis means the XPath should start with / instead of //.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants