Skip to content

Validate configs #2195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MichaelChirico opened this issue Sep 19, 2023 · 0 comments · Fixed by #2225
Closed

Validate configs #2195

MichaelChirico opened this issue Sep 19, 2023 · 0 comments · Fixed by #2225
Labels
config feature a feature request or enhancement
Milestone

Comments

@MichaelChirico
Copy link
Collaborator

          I would actually err on the side of safety and suggest consciously using `rm()` or `local()` if temporary variables are needed.

Re validation:

linters should be a list of linters (we already have that validation somewhere).
Exclusions should also be checked "manually".
The rest seems okay to check against types of default_settings.

But most importantly, no unused variable should be defined. And yes, the validation should be executed after loading the config from either source.

Originally posted by @AshesITR in #2177 (comment)

There's also more discussion in the PR about validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config feature a feature request or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants