fix lint-order in the knitr-format tests

Each of the knitr-format tests had code blocks that look like this:

~~~~
a = 1
~~~~

~~~~
b <- function(x) {
  d = 1
}

~~~~

The tests for the lints found in these blocks were misordered (revealed
once the object-usage-linter line-numbers had been fixed). The lints
should be ordered:
- assignment (`=` for a)
- local variable ‘d’ assigned but may not be used
- assignment (`=` for d)
- trailing blank line

I updated the tests and added the explicit line-numbers where the lints
should throw to test-knitr_formats.R

Author: russHyde

tests/testthat/test-knitr_formats.R

@@ -12,65 +12,65 @@ test_that("it handles dir", {
 test_that("it handles markdown", {
   expect_lint(file = "knitr_formats/test.Rmd",
     checks = list(
-      rex("local variable"),
-      rex("Use <-, not =, for assignment."),
-      rex("Use <-, not =, for assignment."),
-      rex("Trailing blank lines are superfluous.")
+      list(rex("Use <-, not =, for assignment."), line_number = 9),
+      list(rex("local variable"), line_number = 22),
+      list(rex("Use <-, not =, for assignment."), line_number = 22),
+      list(rex("Trailing blank lines are superfluous."), line_number = 24)
     ),
     default_linters
   )
 })
 test_that("it handles Sweave", {
   expect_lint(file = "knitr_formats/test.Rnw",
     checks = list(
-      rex("local variable"),
-      rex("Use <-, not =, for assignment."),
-      rex("Use <-, not =, for assignment."),
-      rex("Trailing blank lines are superfluous.")
+      list(rex("Use <-, not =, for assignment."), line_number = 12),
+      list(rex("local variable"), line_number = 24),
+      list(rex("Use <-, not =, for assignment."), line_number = 24),
+      list(rex("Trailing blank lines are superfluous."), line_number = 26)
     ),
     default_linters
   )
 })
 test_that("it handles reStructuredText", {
   expect_lint(file = "knitr_formats/test.Rrst",
     checks = list(
-      rex("local variable"),
-      rex("Use <-, not =, for assignment."),
-      rex("Use <-, not =, for assignment."),
-      rex("Trailing blank lines are superfluous.")
+      list(rex("Use <-, not =, for assignment."), line_number = 10),
+      list(rex("local variable"), line_number = 23),
+      list(rex("Use <-, not =, for assignment."), line_number = 23),
+      list(rex("Trailing blank lines are superfluous."), line_number = 25)
     ),
     default_linters
   )
 })
 test_that("it handles HTML", {
   expect_lint(file = "knitr_formats/test.Rhtml",
     checks = list(
-      rex("local variable"),
-      rex("Use <-, not =, for assignment."),
-      rex("Use <-, not =, for assignment."),
-      rex("Trailing blank lines are superfluous.")
+      list(rex("Use <-, not =, for assignment."), line_number = 15),
+      list(rex("local variable"), line_number = 27),
+      list(rex("Use <-, not =, for assignment."), line_number = 27),
+      list(rex("Trailing blank lines are superfluous."), line_number = 29)
     ),
     default_linters
   )
 })
 test_that("it handles tex", {
   expect_lint(file = "knitr_formats/test.Rtex",
     checks = list(
-      rex("local variable"),
-      rex("Use <-, not =, for assignment."),
-      rex("Use <-, not =, for assignment."),
-      rex("Trailing blank lines are superfluous.")
+      list(rex("Use <-, not =, for assignment."), line_number = 11),
+      list(rex("local variable"), line_number = 23),
+      list(rex("Use <-, not =, for assignment."), line_number = 23),
+      list(rex("Trailing blank lines are superfluous."), line_number = 25)
     ),
     default_linters
   )
 })
 test_that("it handles asciidoc", {
   expect_lint(file = "knitr_formats/test.Rtxt",
     checks = list(
-      rex("local variable"),
-      rex("Use <-, not =, for assignment."),
-      rex("Use <-, not =, for assignment."),
-      rex("Trailing blank lines are superfluous.")
+      list(rex("Use <-, not =, for assignment."), line_number = 9),
+      list(rex("local variable"), line_number = 22),
+      list(rex("Use <-, not =, for assignment."), line_number = 22),
+      list(rex("Trailing blank lines are superfluous."), line_number = 24)
     ),
     default_linters
   )