Skip to content

Commit 408de29

Browse files
Mariattawillingc
authored andcommitted
Document when a review can be dismissed. (#176)
Closes #161
1 parent ebc8a79 commit 408de29

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

pullrequest.rst

+9
Original file line numberDiff line numberDiff line change
@@ -323,6 +323,15 @@ code and leave comments in the pull request or issue tracker.
323323
'merge-ready', you should always make sure the entire test suite passes.
324324

325325

326+
Dismissing Review from Another Core Developer
327+
---------------------------------------------
328+
329+
A core developer can dismiss another core developer's review if they confirmed
330+
that the requested changes have been made. When a core developer has assigned
331+
the PR to themselves, then it is a sign that they are actively looking after
332+
the PR, and their review should not be dismissed.
333+
334+
326335
Committing/Rejecting
327336
--------------------
328337

0 commit comments

Comments
 (0)